New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709332 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 683226
issue 733482
issue 851488

Blocking:
issue 841446
issue 860241



Sign in to add a comment

Complete mojom.GpuHost implementation for mus

Project Member Reported by sadrul@chromium.org, Apr 7 2017

Issue description

mojom.GpuHost implementation in mus [1] is fairly trivial, and misses functionality. The implementation in chrome [2] is complete. We need to refactor the implementation in chrome in a way that allows sharing between mus and chrome.

[1] https://cs.chromium.org/chromium/src/services/ui/ws/gpu_host.cc?type=cs
[2] https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_process_host.cc
 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca65d070a3195b1357d3c41edaaba72202470ed7

commit ca65d070a3195b1357d3c41edaaba72202470ed7
Author: sadrul <sadrul@chromium.org>
Date: Mon Apr 10 18:08:13 2017

gpu: Some cleanups.

. Use SANDBOXED as the default argument to GpuProcessHost::Get(), since
  that's the most common use.
. Remove unused ash::GPUSupport::GetGpuProcessHandles().
. Remove unused content::GpuDataManager::GetGpuProcessHandles().
. Replace GpuProcessHost::GetProcessHandles() with GetHasGpuProcess(),
  since the only remaining user (RenderMessageFilter) cares only about
  the existence of a gpu process, and not about what those processes are.

BUG=417532,  709332 

Review-Url: https://codereview.chromium.org/2810593003
Cr-Commit-Position: refs/heads/master@{#463324}

[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/ash/content/gpu_support_impl.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/ash/content/gpu_support_impl.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/ash/gpu_support.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/ash/gpu_support_stub.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/ash/gpu_support_stub.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/gpu_client.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/gpu_data_manager_impl.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/gpu_data_manager_impl.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/gpu_data_manager_impl_private.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/public/browser/gpu_data_manager.h
[modify] https://crrev.com/ca65d070a3195b1357d3c41edaaba72202470ed7/content/public/browser/gpu_service_registry.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4784619fba45abbf811939fe143c1378fe003246

commit 4784619fba45abbf811939fe143c1378fe003246
Author: sadrul <sadrul@chromium.org>
Date: Mon Apr 10 22:07:12 2017

gpu: Simplify the error handling during gpu memory buffer allocation.

Notify BrowserGpuMemoryBufferManager from GpuProcessHost the reason for
failure to allocate gpu memory buffer. The gmb-manager then uses that
information to decide whether it can try again. This allows simplifying
the relevant code in BrowserGpuMemoryBufferManager.

BUG= 709332 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2811513002
Cr-Commit-Position: refs/heads/master@{#463414}

[modify] https://crrev.com/4784619fba45abbf811939fe143c1378fe003246/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/4784619fba45abbf811939fe143c1378fe003246/content/browser/gpu/browser_gpu_memory_buffer_manager.h
[modify] https://crrev.com/4784619fba45abbf811939fe143c1378fe003246/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/4784619fba45abbf811939fe143c1378fe003246/content/browser/gpu/gpu_process_host.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9

commit f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9
Author: sadrul <sadrul@chromium.org>
Date: Fri Apr 21 15:26:02 2017

gpu:: Remove GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate().

TaskManagerImpl is the only observer which requires this callback. In
order to get the video memory usage, TaskManagerImpl installs itself as
an observer, makes the request through GpuDataManager, and waits for the
observer callback to be called. Instead, change this so the request to
GpuDataManager::RequestVideoMemoryUsageStatsUpdate() includes the
callback that needs to run when the stats become available.

BUG= 709332 

Review-Url: https://codereview.chromium.org/2827323002
Cr-Commit-Position: refs/heads/master@{#466341}

[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/chrome/browser/task_manager/sampling/task_manager_impl.h
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/content/browser/gpu/gpu_data_manager_impl.cc
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/content/browser/gpu/gpu_data_manager_impl.h
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/content/browser/gpu/gpu_data_manager_impl_private.h
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/content/public/browser/gpu_data_manager.h
[modify] https://crrev.com/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9/content/public/browser/gpu_data_manager_observer.h

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63c1e2603b28e1fb6a2ca120e793497ed3b37220

commit 63c1e2603b28e1fb6a2ca120e793497ed3b37220
Author: sadrul <sadrul@chromium.org>
Date: Fri Apr 21 16:00:55 2017

gpu: Completely remove GpuProcessHostUIShim.

The only remaining purpose of GpuProcessHostUIShim was to send messages
back and forth between GpuProcessHost and the ozone platform. Move that
relevant code into GpuProcessHost, and remove the ui shim.

For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is
currently needed only for the drm implementation, and is essentially just
a thread hop from the IO thread to the UI thread. So do that from inside
the drm implementation, instead of having a public API and requiring the
gpu host do the thread-hop.

BUG= 709332 , 711333

Review-Url: https://codereview.chromium.org/2820463002
Cr-Commit-Position: refs/heads/master@{#466351}

[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/content/browser/BUILD.gn
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/content/browser/browser_main_loop.cc
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/content/browser/gpu/gpu_process_host.h
[delete] https://crrev.com/80d0234a6c13bba1e14ca76f48d7c437fe5b020e/content/browser/gpu/gpu_process_host_ui_shim.cc
[delete] https://crrev.com/80d0234a6c13bba1e14ca76f48d7c437fe5b020e/content/browser/gpu/gpu_process_host_ui_shim.h
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/ui/ozone/public/gpu_platform_support_host.cc
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/ui/ozone/public/gpu_platform_support_host.h
[modify] https://crrev.com/63c1e2603b28e1fb6a2ca120e793497ed3b37220/ui/ozone/public/ozone_gpu_test_helper.cc

Comment 6 by sky@chromium.org, Jun 8 2017

Blocking: 731255

Comment 7 by sadrul@chromium.org, Jun 13 2017

Blocking: 732805

Comment 8 by sadrul@chromium.org, Jun 15 2017

Blockedon: 733482
Blocking: -732805
This isn't a blocker for Viz on Linux or Viz on Chrome OS on its own. This is a servicification task, so I'm removing the latest blocker.
Cc: moh...@chromium.org

Comment 11 by fsamuel@google.com, Oct 20 2017

Labels: -Pri-1 Pri-2

Comment 12 by sky@chromium.org, Oct 26 2017

Blocking: -731255
Components: -Internals>MUS Internals>Services>WindowService

Comment 14 by sky@chromium.org, May 30 2018

Blocking: 841446
Cc: sadrul@chromium.org
Owner: moh...@chromium.org
Status: Assigned (was: Started)
The work here is to move GpuProcessHost out of content into viz (specifically: components/viz/host)
Blockedon: 851488
Blockedon: 683226
Blocking: 860241
Labels: -Proj-Mustash-Mus-GPU
Cleaning up old Proj-Mustash labels.
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb8218b7d5a8553500fd93ce0fdfa349e15e536

commit 4bb8218b7d5a8553500fd93ce0fdfa349e15e536
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Fri Aug 17 01:50:59 2018

Remove GpuProcessHost::RequestGPUInfo()

This is essentially a revert of crrev/c/544480 as the function is not
used anymore; in preparation of moving viz::mojom::GpuHost
implementation to //components/viz/host/.

BUG= 709332 

Change-Id: Ib3b73a7250f3f838d2699a06261bb8079b93db3c
Reviewed-on: https://chromium-review.googlesource.com/1178327
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583935}
[modify] https://crrev.com/4bb8218b7d5a8553500fd93ce0fdfa349e15e536/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/4bb8218b7d5a8553500fd93ce0fdfa349e15e536/content/browser/gpu/gpu_process_host.h

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/168300f9640000
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6

commit 0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Thu Aug 30 20:30:00 2018

Move viz::mojom::GpuHost implementation out of content

This CL moves portions of GpuProcessHost that implement
viz::mojom::GpuHost out of content into //components/viz/host/ as
GpuHostImpl.  GpuHostImpl also owns GpuServicePtr, so parts of
GpuProcessHost that work directly with GPU service are also moved.
Whenever needed, GpuHostImpl accesses content through its Delegate
interface implemented by GpuProcessHost. This is mostly needed to access
content::GpuDataManager.

BUG= 709332 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5f27805aff16fe7db753c4700dbab5bf5ee0812d
Reviewed-on: https://chromium-review.googlesource.com/1180658
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587741}
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/components/viz/host/BUILD.gn
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/components/viz/host/DEPS
[add] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/components/viz/host/gpu_host_impl.cc
[add] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/components/viz/host/gpu_host_impl.h
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/browser_main_loop.cc
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/devtools/protocol/tracing_handler.cc
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/gpu/browser_gpu_client_delegate.cc
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/0b9fbb6f587afd7b0f3c31ce449a360b8d7206b6/content/browser/renderer_host/render_widget_host_view_android.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c63949de600ac796e2d7969719f7862a91e7fb8

commit 1c63949de600ac796e2d7969719f7862a91e7fb8
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Thu Aug 30 23:49:23 2018

Establish channel directly from viz::GpuClient

Now that viz::mojom::GpuHost implementation has moved out of content,
viz::GpuClient can directly call on that to establish a gpu channel and
we can remove the functionality from GpuClientDelegate.

BUG= 709332 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ied5a8ead810973068190e3ce485609f68f5826d5
Reviewed-on: https://chromium-review.googlesource.com/1188883
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587852}
[modify] https://crrev.com/1c63949de600ac796e2d7969719f7862a91e7fb8/components/viz/host/gpu_client.cc
[modify] https://crrev.com/1c63949de600ac796e2d7969719f7862a91e7fb8/components/viz/host/gpu_client.h
[modify] https://crrev.com/1c63949de600ac796e2d7969719f7862a91e7fb8/components/viz/host/gpu_client_delegate.h
[modify] https://crrev.com/1c63949de600ac796e2d7969719f7862a91e7fb8/content/browser/gpu/browser_gpu_client_delegate.cc
[modify] https://crrev.com/1c63949de600ac796e2d7969719f7862a91e7fb8/content/browser/gpu/browser_gpu_client_delegate.h

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/babed2b57af4ca4c6f51cd12368f51b1273a5edf

commit babed2b57af4ca4c6f51cd12368f51b1273a5edf
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Fri Aug 31 01:37:39 2018

Add connection error handlers to viz::GpuHostImpl

Before this CL, they were in content::GpuProcessHost.

BUG= 709332 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9183ed0fc7c5baec2ea98fd3e68d8a8910fc41d4
Reviewed-on: https://chromium-review.googlesource.com/1195679
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587903}
[modify] https://crrev.com/babed2b57af4ca4c6f51cd12368f51b1273a5edf/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/babed2b57af4ca4c6f51cd12368f51b1273a5edf/components/viz/host/gpu_host_impl.h
[modify] https://crrev.com/babed2b57af4ca4c6f51cd12368f51b1273a5edf/content/browser/gpu/gpu_memory_buffer_manager_singleton.cc
[modify] https://crrev.com/babed2b57af4ca4c6f51cd12368f51b1273a5edf/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/babed2b57af4ca4c6f51cd12368f51b1273a5edf/content/browser/gpu/gpu_process_host.h

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63d85e796752ba5c3e229602c0ea833eba23b3c8

commit 63d85e796752ba5c3e229602c0ea833eba23b3c8
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Thu Sep 06 16:00:21 2018

Add InitOzone() to viz::GpuHostImpl

Moving InitOzone() from content::GpuProcessHost to viz::GpuHostImpl as
part of moving viz::mojom::GpuHost implementation out of content. This
is a follow-up to https://crrev.com/c/1180658.

BUG= 709332 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I022ee15c3a1f194313bf2566e9503e357cd46494
Reviewed-on: https://chromium-review.googlesource.com/1195151
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589178}
[modify] https://crrev.com/63d85e796752ba5c3e229602c0ea833eba23b3c8/components/viz/host/DEPS
[modify] https://crrev.com/63d85e796752ba5c3e229602c0ea833eba23b3c8/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/63d85e796752ba5c3e229602c0ea833eba23b3c8/components/viz/host/gpu_host_impl.h
[modify] https://crrev.com/63d85e796752ba5c3e229602c0ea833eba23b3c8/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/63d85e796752ba5c3e229602c0ea833eba23b3c8/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/63d85e796752ba5c3e229602c0ea833eba23b3c8/content/public/browser/gpu_service_registry.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50c28059f282dbbeb1c12c419d57d72a2b9ae623

commit 50c28059f282dbbeb1c12c419d57d72a2b9ae623
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Fri Sep 07 00:32:14 2018

Some cleanup to GpuHost implementation

This a a follow-up to introducing viz::GpuHostImpl (crrev/c/1180658).
This includes:
 - Removing an expired CHECK;
 - Limiting GpuHost::SetChildSurface() to Windows;
 - Removing unused GpuProcessHost::OnDestroyingVideoSurfaceAck().

BUG= 709332 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ida7488d887ff5d511b53e8e6997835486572b648
Reviewed-on: https://chromium-review.googlesource.com/1195545
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589381}
[modify] https://crrev.com/50c28059f282dbbeb1c12c419d57d72a2b9ae623/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/50c28059f282dbbeb1c12c419d57d72a2b9ae623/components/viz/host/gpu_host_impl.h
[modify] https://crrev.com/50c28059f282dbbeb1c12c419d57d72a2b9ae623/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/50c28059f282dbbeb1c12c419d57d72a2b9ae623/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/50c28059f282dbbeb1c12c419d57d72a2b9ae623/services/viz/privileged/interfaces/gl/gpu_host.mojom
[modify] https://crrev.com/50c28059f282dbbeb1c12c419d57d72a2b9ae623/services/ws/gpu_host/gpu_host.cc
[modify] https://crrev.com/50c28059f282dbbeb1c12c419d57d72a2b9ae623/services/ws/gpu_host/gpu_host.h

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/312c692ada942ec6b82c4a6ee1697091654ea830

commit 312c692ada942ec6b82c4a6ee1697091654ea830
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Fri Sep 07 14:21:36 2018

Add gpu::DomainGuilt to //gpu/config/

It replaces content::GpuDataManagerImpl::DomainGuilt and
viz::GpuHostImpl::Delegate::DomainGuilt.

BUG= 709332 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5a802e53ec770835954b77ba62e9fe9920377381
Reviewed-on: https://chromium-review.googlesource.com/1201704
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589513}
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/components/viz/host/gpu_host_impl.cc
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/components/viz/host/gpu_host_impl.h
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/content/browser/gpu/gpu_data_manager_impl.cc
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/content/browser/gpu/gpu_data_manager_impl.h
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/content/browser/gpu/gpu_data_manager_impl_private.h
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/gpu/config/BUILD.gn
[add] https://crrev.com/312c692ada942ec6b82c4a6ee1697091654ea830/gpu/config/gpu_domain_guilt.h

Status: Fixed (was: Assigned)

Sign in to add a comment