New issue
Advanced search Search tips

Issue 709324 link

Starred by 1 user
Status: Fixed
Owner:
nedngu...@google.com
Closed: Apr 2017
Cc:
dpranke@chromium.org
martiniss@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename ignore_swarming_task_failure to ignore_task_failure

Project Member Reported by nedngu...@google.com, Apr 7 2017 
This is carried from the discussion in https://chromium-review.googlesource.com/c/458261/#message-251e7d24028c1b74ae5e6bc8c6c20c424436dbea. We want to rename the field "ignore_swarming_task_failure" to "ignore_task_failure" to make it less verbose & not specific to swarming.

Plan:
1) Support both "ignore_swarming_task_failure" & "ignore_task_failure"
2) Switch recipe in perf to use "ignore_task_failure"
3) Remove "ignore_swarming_task_failure"

Comment 1 by nedngu...@google.com, Apr 7 2017

Components: Speed>Benchmarks>Waterfall
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3722c6c9b98063a27319ba3f97e0d6bbd538a884

commit 3722c6c9b98063a27319ba3f97e0d6bbd538a884
Author: Nghia Nguyen <nednguyen@google.com>
Date: Fri Apr 07 21:17:43 2017

Support specifying ignore_swarming_task_failure & ignore_task_failure for swarming isolated script test

This is the first CL in our 3-sided patches to rename ignore_swarming_task_failure
to ignore_task_failure.

BUG= 709324 

Change-Id: I744fc3512335bdeae045d3724a5b646120dc7030
Reviewed-on: https://chromium-review.googlesource.com/471026
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[add] https://crrev.com/3722c6c9b98063a27319ba3f97e0d6bbd538a884/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_task_failure.json
[modify] https://crrev.com/3722c6c9b98063a27319ba3f97e0d6bbd538a884/scripts/slave/recipes/chromium.py
[rename] https://crrev.com/3722c6c9b98063a27319ba3f97e0d6bbd538a884/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_swarming_task_failure.json
[modify] https://crrev.com/3722c6c9b98063a27319ba3f97e0d6bbd538a884/scripts/slave/recipe_modules/swarming/api.py
[modify] https://crrev.com/3722c6c9b98063a27319ba3f97e0d6bbd538a884/scripts/slave/recipe_modules/chromium_tests/steps.py
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22f0a7ab19cbbd1b8cac600230f90e6b3147b37d

commit 22f0a7ab19cbbd1b8cac600230f90e6b3147b37d
Author: Nghia Nguyen <NghiaNguyenBH@gmail.com>
Date: Fri Apr 07 22:00:36 2017

Switch 'ignore_swarming_task_failure' to 'ignore_task_failure'

This is the 2nd CL in our 3-sided patches to rename 'ignore_swarming_task_failure' to 'ignore_task_failure'

BUG= 709324 

Change-Id: I52efa1bbfd57585e5e28abc6876acbf6ca88af41
Reviewed-on: https://chromium-review.googlesource.com/471046
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#463017}
[modify] https://crrev.com/22f0a7ab19cbbd1b8cac600230f90e6b3147b37d/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/22f0a7ab19cbbd1b8cac600230f90e6b3147b37d/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/22f0a7ab19cbbd1b8cac600230f90e6b3147b37d/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/22f0a7ab19cbbd1b8cac600230f90e6b3147b37d/tools/perf/core/perf_data_generator_unittest.py

Comment 4 by nedngu...@google.com, Apr 10 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/75c17b641b40ff75b5fcb90b4ec87b3eb91290bc

commit 75c17b641b40ff75b5fcb90b4ec87b3eb91290bc
Author: nednguyen <nednguyen@google.com>
Date: Mon Apr 10 19:44:37 2017

Remove ignore_swarming_task_failure field

This is the final CL in our 3-sided patches to rename
'ignore_swarming_task_failure' to 'ignore_task_failure'


BUG= 709324 

Change-Id: I0e2843e039f301782445273d27050e7ffb54942f
Reviewed-on: https://chromium-review.googlesource.com/472967
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/75c17b641b40ff75b5fcb90b4ec87b3eb91290bc/scripts/slave/recipes/chromium.py
[delete] https://crrev.com/da635f7814c920356afaa25eebef15f010e9333e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_swarming_task_failure.json
[modify] https://crrev.com/75c17b641b40ff75b5fcb90b4ec87b3eb91290bc/scripts/slave/recipe_modules/chromium_tests/steps.py
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/75c17b641b40ff75b5fcb90b4ec87b3eb91290bc

commit 75c17b641b40ff75b5fcb90b4ec87b3eb91290bc
Author: nednguyen <nednguyen@google.com>
Date: Mon Apr 10 19:44:37 2017

Remove ignore_swarming_task_failure field

This is the final CL in our 3-sided patches to rename
'ignore_swarming_task_failure' to 'ignore_task_failure'


BUG= 709324 

Change-Id: I0e2843e039f301782445273d27050e7ffb54942f
Reviewed-on: https://chromium-review.googlesource.com/472967
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/75c17b641b40ff75b5fcb90b4ec87b3eb91290bc/scripts/slave/recipes/chromium.py
[delete] https://crrev.com/da635f7814c920356afaa25eebef15f010e9333e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_swarming_task_failure.json
[modify] https://crrev.com/75c17b641b40ff75b5fcb90b4ec87b3eb91290bc/scripts/slave/recipe_modules/chromium_tests/steps.py
►

Sign in to add a comment