CRAS: reduce ramping time from 0.5 second to shorter |
||||
Issue descriptionWe should use a ramping time that is minimum to avoid pop noise. Currently it is 1 second. I should check on samus and kevin and see how short we can get.
,
Apr 10 2017
https://chromium-review.googlesource.com/472327 posted. The new durations: RAMP_UNMUTE_DURATION_SECS = 0.5; RAMP_NEW_STREAM_DURATION_SECS = 0.01; RAMP_MUTE_DURATION_SECS = 0.1; Keep unmute duration to 0.5 and tune the ramp duration for new stream and mute shorter. Thanks!
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/d4c8bcdbc8df5a1e6c0929e3747f39a9a89dd075 commit d4c8bcdbc8df5a1e6c0929e3747f39a9a89dd075 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Mon Apr 17 05:39:02 2017 CRAS: iodev - Tune the ramp duration Set ramp duration for new stream to 0.01 so user does not miss the start of new stream. Set ramp duration for mute to 0.1 so mute can happen sooner. BUG= chromium:709323 TEST=make check TEST=check ramp duration for new stream is almost not noticeable. TEST=check ramp duration for mute is much shorter than before. Change-Id: If74d094aad11748e3198e8e9402a4d4de9631694 Reviewed-on: https://chromium-review.googlesource.com/472327 Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/d4c8bcdbc8df5a1e6c0929e3747f39a9a89dd075/cras/src/tests/iodev_unittest.cc [modify] https://crrev.com/d4c8bcdbc8df5a1e6c0929e3747f39a9a89dd075/cras/src/server/cras_iodev.c
,
Apr 18 2017
,
May 19 2017
Verified in Chrome OS 9565.0.0;60.0.3102.0. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dgreid@chromium.org
, Apr 7 2017