New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709313 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Enterprise Device Policy Login Input Methods is not switched with user pod focus change

Project Member Reported by jingwee@chromium.org, Apr 7 2017

Issue description

Chrome Version: 58.0.3029.51 beta
OS: ChromeOS 9334.33.0 beta reks

What steps will reproduce the problem?
(1) Policies on YAPS:
    DeviceShowUserNamesOnSignin=true
    DeviceLoginScreenInputMethods=xkb:us::eng,xkb:ch::ger
(2) Enroll device and sign in as user.
(3) Go to settings and add languages such as French, German and their associated keyboards.
(4) Exit settings and select FR keyboard from bottom right of screen. If FR is unavailable, sign-out, sign-in and try again.
(5) Sign-out. In the Sign-in screen, FR is current input method with the current user pod in focus.
(6) Click on "Add person". Since FR is only associated to the previous user session, it is expected the first mandated policy input method should be switched in i.e. US keyboard. However, FR remains as the input method in the Sign-in screen.


What is the expected result?

With reference to go/cros-locale-input-policy-dd:

1. When a user focuses their pod on the Sign-in screen, the user’s least-recently-used Input Method (LRU Input Method) will be loaded from the local state and switched to.

2. When a user pod loses focus on the Sign-in screen, the Input Method will switch back to the Input Method mandated by policy for the Sign-In screen.


What happens instead?

Without changing the input method manually, the user's least-recently-used Input Method stays as the current input method throughout the Sign-In screen whether the user pod is in focus or not.


Reference to the Feature Request for Login screen Input Methods:
https://bugs.chromium.org/p/chromium/issues/detail?id=373324
 

Comment 1 by pmarko@chromium.org, Apr 12 2017

Status: Started (was: Untriaged)
I was able to reproduce this issue.
When there is exactly on user pod on the sign-in screen, there is no "pod unfocused" event when jumping into the "Add person" / gaia sign-in screen, so the unfocus pod handling does not apply.

Planned fix:
Explicitly re-enforce user independent input methods on "Add person".
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca7672ad2527bb65ca0a1bc76d8e369f4a4c0729

commit ca7672ad2527bb65ca0a1bc76d8e369f4a4c0729
Author: pmarko <pmarko@chromium.org>
Date: Wed Apr 12 23:24:24 2017

Login screen IME policy does not apply in user session

This CL fixes issues with the DeviceLoginScreenInputMethods policy:
+ SigninScreenHandler is now only enforcing input methods on if the
  sign-in screen is visible. This prevents a SigninScreenHandler
  instance which exists during the user session from enforcing input
  methods in the user session.
+ SigninScreenHandler re-enforces input methods on the "addUser" event,
  because if only one user pod is present on the sign-in screen,
  pressing addUser does not de-focus the user pod before switching to
  the gaia screen.
+ Prefer policy-allowed input methods on the gaia screen ("Add Person")

BUG= 373324 , 709313 
TEST=Manual test && browser_tests --gtest_filter=LoginScreen*

Review-Url: https://codereview.chromium.org/2816543004
Cr-Commit-Position: refs/heads/master@{#464204}

[modify] https://crrev.com/ca7672ad2527bb65ca0a1bc76d8e369f4a4c0729/chrome/browser/chromeos/login/login_screen_policy_browsertest.cc
[modify] https://crrev.com/ca7672ad2527bb65ca0a1bc76d8e369f4a4c0729/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/ca7672ad2527bb65ca0a1bc76d8e369f4a4c0729/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Comment 3 by pmarko@chromium.org, Apr 13 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified the issue was fixed as tested in M59.0.3071.15:9460.5.0 dev peppy. Switching different users during the login would automatically switch to the user's last input method.

Sign in to add a comment