New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709311 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
emilyschechter@chromium.org
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Verbose state in incognito doesn't have #FFFFFF text

Project Member Reported by lgar...@chromium.org, Apr 7 2017 
Chrome 59.0.3063.4
OSX 10.12.3

What steps will reproduce the problem?
(1) Visit http://http-password.badssl.com/

What is the expected result?
The security icon, verbose state text, and domain are all #FFFFFF white.

What happens instead?
The verbose state is #DFDFDF.

spqchan@, could you triage?
Screen Shot 2017-04-06 at 17.59.39.png
16.6 KB View Download

Comment 1 by lgar...@chromium.org, Apr 7 2017

Summary: Verbose state in incognito doesn't have #FFFFFF text (was: Verbose state in incognito doesn't have white text)

Comment 2 by shrike@chromium.org, May 6 2017

Cc: shrike@chromium.org
Here's what I found for a spec on this. It doesn't seem like all of the text should be white?

https://drive.google.com/corp/drive/u/0/folders/0B6Wxmj9LZL6XZjJURlVaN1hUTzQ
Non-Touch-Scheme-Color.png
166 KB View Download

Comment 3 by lgar...@chromium.org, May 6 2017 

The entire domain should certainly be white.

I'm talking about the verbose state text, though, which the specs in that folder show as white.
Non-Touch-Chip-Incognito.png
69.5 KB View Download
Non-Touch-Chip-Chrome-Incognito.png
168 KB View Download

Comment 4 by spqc...@chromium.org, May 7 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4c5806ef59df14009ad9258ad98d231c5fe1699

commit c4c5806ef59df14009ad9258ad98d231c5fe1699
Author: spqchan <spqchan@chromium.org>
Date: Tue May 09 04:20:59 2017

[Mac] Fix for the Verbose State Text Color

The text color should be white in incognito.

BUG= 709311 

Review-Url: https://codereview.chromium.org/2872503005
Cr-Commit-Position: refs/heads/master@{#470198}

[modify] https://crrev.com/c4c5806ef59df14009ad9258ad98d231c5fe1699/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm

Comment 6 by spqc...@chromium.org, May 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment