Issue metadata
Sign in to add a comment
|
Default favicon is low contrast in focused Incognito window (and dark themes) |
||||||||||||||||||||||||
Issue descriptionChrome 59.0.3063.4 OSX 10.12.3 What steps will reproduce the problem? (1) Visit a site without a favicon in Incognito What is the expected result? The page icon that shows in the tab strip is visible. What happens instead? The page icon is always #5A5A5A. A focused incognito window has a default tab color of #505050, which gives this an extremely low contrast ratio of 1.2: http://leaverou.github.io/contrast-ratio/#%23505050-on-%235a5a5a When the incognito window is the the background, the tab color changes to #2D2D2D, which gives this a slightly-better-but-not-great contrast of 2: http://leaverou.github.io/contrast-ratio/#%232d2d2d-on-%235a5a5a The regular (non-Incognito) contrast is 6.2, which is excellent. The contrast is also bad for dark themes. (dark-theme.png) That is less important than the out-of-the-box incognito experience, but it would be nice to fix, too.
,
Aug 8 2017
Per the MD Top Chrome previews, the page icon on a dark bg is #FFF rgba(255,255,255,1). https://goto.google.com/pi709307 Is the icon a vector file that we can color in the code?
,
Aug 8 2017
I get #ffffff on Windows. Is this mis-tagged and is a mac-tabstrip-only bug? Or have we confirmed it on other platforms? I'm gonna assume for the moment that this is Mac.
,
Aug 8 2017
ChromeOS is #fff. So looks like it's a Mac bug. I'll check Linux tomorrow as well just to be sure.
,
Aug 8 2017
Confirmed the existence of this bug on Mac. I'll take a look.
,
Aug 8 2017
Probably the code in [TabStripController initWithView:switchView:browser:delegate:] needs to do the same thing as the views Tab::PaintIcon does - ie:
favicon_ = gfx::ImageSkiaOperations::CreateHSLShiftedImage(
favicon_, GetThemeProvider()->GetTint(ThemeProperties::TINT_BUTTONS));
I'll have a try implementing this some time this week.
,
Aug 9 2017
,
Aug 9 2017
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e78297f19a802b8e4f26b170f2e4c026a226fba7 commit e78297f19a802b8e4f26b170f2e4c026a226fba7 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Aug 09 18:53:09 2017 cocoa: draw default favicon in theme color This makes the default favicon more visible on dark themes. Bug: 709307 Change-Id: I86ff398f1ec046bd2990dfb5f729b96884fdc5a7 Reviewed-on: https://chromium-review.googlesource.com/608512 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#493076} [modify] https://crrev.com/e78297f19a802b8e4f26b170f2e4c026a226fba7/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm
,
Aug 9 2017
,
Aug 10 2017
Tested the issue on Mac OS 10.12.6 using Chrome Canary version M62 - 62.0.3181.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Default fav icon is displayed properly in different modes of Chrome browser). Hence adding TE-Verified label. Attached the screenshot for reference. Thank you!
,
Aug 11 2017
The NextAction date has arrived: 2017-08-11 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lpalmaro@chromium.org
, Aug 7 2017Status: Available (was: Untriaged)