Geolocation servicification |
|||||||||||||||
Issue descriptionMove Geolocation from //device/geolocation to //services/device/geolocation. More information in blundell@s document [1]. This is part of a larger servification effort in Chrome (see https://crbug.com/612328). [1] https://docs.google.com/document/d/1V-HsypJveArl_LQox4ksxC7kTl7vnhlCudhbU6o0tRQ/edit#heading=h.rsbi7z86ug1u
,
Apr 19 2017
,
May 1 2017
,
May 22 2017
,
Jun 2 2017
,
Sep 22 2017
,
Sep 22 2017
,
Sep 29 2017
Note that when doing the code move, we'll need to put location_provider.h in //services/device/public/cpp/ in order to allow clients to implement that interface to override the system location provider.
,
Sep 29 2017
,
Oct 27 2017
,
Nov 7 2017
,
Nov 10 2017
Hi, Colin, is there issue track the "inject the URLRequestContextGetter and ApiKeyGetter" to ctor of DeviceService? I think we should set it as blocker to this issue? Or anyone (Hi, amoylan@ ?) already start working on it? If no, I'll do it. Just make sure no duplication work:)
,
Nov 10 2017
This is indeed planned to happen as part of implementation of IP geolocation. Specifically in the fourth CL in the chain: crrev.com/c/754256 +renjieliu who is taking over shepherding these as I am on baby leave.
,
Nov 10 2017
I suggest that rather than blocking this effort on that one, Ke He, if you get to the point where you're ready to host geolocation in the Device Service and the CL mentioned in c#13 isn't yet landed, you and Renjie coordinate to see who's closer to landing an addition of the injection code :).
,
Nov 24 2017
,
Nov 28 2017
Hi, Renjie, I'm going to work on "injecting URLRequestContextGetter and ApiKeyGetter" as Colin suggested. Now all the parallel works are done, Seems this injection is the only thing block us to move on.
,
Nov 28 2017
Renjie, I found you just updated the 754256 one day ago, please let me know if that CL will be landed soon?
,
Nov 28 2017
Hi Ke, that cl is currently blocked by ccrev.com/c/784533 which blocked by ccrev.com/c/788477, so if will be helpful if you can check in "injecting URLRequestContextGetter and ApiKeyGetter" :) Thanks a lot!
,
Nov 28 2017
Renjie, thanks! I cannot open the link of ccrev.com. But I think the "injecting URLRequestContextGetter and ApiKeyGetter" can be landed alone regardless of those blockers, right? If it is, I'll start to do it.
,
Nov 28 2017
Yes, I think that can be landed alone :)
,
Nov 28 2017
Those links should be "crrev.com".
,
Jan 9 2018
,
Jan 10 2018
,
Jun 29 2018
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by blundell@chromium.org
, Apr 18 2017