New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709301 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

Geolocation servicification

Project Member Reported by mcasas@chromium.org, Apr 7 2017

Issue description

Move Geolocation from //device/geolocation to //services/device/geolocation.

More information in blundell@s document [1]. This is part 
of a larger servification effort in Chrome (see https://crbug.com/612328). 


[1] https://docs.google.com/document/d/1V-HsypJveArl_LQox4ksxC7kTl7vnhlCudhbU6o0tRQ/edit#heading=h.rsbi7z86ug1u
 
Labels: DeviceService

Comment 2 by mcasas@chromium.org, Apr 19 2017

Summary: Geolocation servicification (was: Geolocation servification)
Blockedon: 717053
Blockedon: 725066
Cc: -dougt@chromium.org amoylan@chromium.org
Components: Blink>Geolocation
Components: -Blink>Location
Note that when doing the code move, we'll need to put location_provider.h in //services/device/public/cpp/ in order to allow clients to implement that interface to override the system location provider.
Blockedon: 748921

Comment 10 by ke...@intel.com, Oct 27 2017

Blockedon: 778989
Components: Internals>Services>Device

Comment 12 by ke...@intel.com, Nov 10 2017

Hi, Colin, is there issue track the "inject the URLRequestContextGetter and ApiKeyGetter" to ctor of DeviceService?  I think we should set it as blocker to this issue?

Or anyone (Hi, amoylan@ ?) already start working on it? If no, I'll do it. Just make sure no duplication work:)
Cc: renjieliu@chromium.org
This is indeed planned to happen as part of implementation of IP geolocation. Specifically in the fourth CL in the chain: crrev.com/c/754256

+renjieliu who is taking over shepherding these as I am on baby leave.
I suggest that rather than blocking this effort on that one, Ke He, if you get to the point where you're ready to host geolocation in the Device Service and the CL mentioned in c#13 isn't yet landed, you and Renjie coordinate to see who's closer to landing an addition of the injection code :).

Comment 15 by ke...@intel.com, Nov 24 2017

Blockedon: 788298

Comment 16 by ke...@intel.com, Nov 28 2017

Hi, Renjie, I'm going to work on "injecting URLRequestContextGetter and ApiKeyGetter" as Colin suggested. Now all the parallel works are done, Seems this injection is the only thing block us to move on.

Comment 17 by ke...@intel.com, Nov 28 2017

Renjie, I found you just updated the 754256 one day ago, please let me know if that CL will be landed soon?
Hi Ke, that cl is currently blocked by ccrev.com/c/784533 which blocked by ccrev.com/c/788477, so if will be helpful if you can check in "injecting URLRequestContextGetter and ApiKeyGetter" :)

Thanks a lot!

Comment 19 by ke...@intel.com, Nov 28 2017

Renjie, thanks! 
I cannot open the link of ccrev.com. But I think the "injecting URLRequestContextGetter and ApiKeyGetter" can be landed alone regardless of those blockers, right? 
If it is, I'll start to do it.
Yes, I think that can be landed alone :)
Those links should be "crrev.com".
Cc: -scheib@chromium.org

Comment 23 by ke...@intel.com, Jan 10 2018

Blockedon: 800659

Comment 24 by ke...@intel.com, Jun 29 2018

Status: Fixed (was: Available)

Sign in to add a comment