Fix CRWWebControllerInvalidUrlTest.LoadInvalidURL |
||
Issue descriptionThe HTML5 spec indicates that navigations (at least via the Location interface) should be treated as no-ops for invalid URLs. CRWWebControllerInvalidUrlTest.LoadInvalidURL checks that the URL is rewritten to about:blank if it's invalid, and it passes because WKWebView's |-loadHTMLString:baseURL:| rewrites invalid URLs to about:blank before the load occurs. It's unclear whether we depend on this behavior of |-loadHTMLString:baseURL:|, or whether we should just delete this test since invalid URL loads occurring via window.location are already tested in the window.location inttests.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5717606707c4bdae7710dc382b3f687e713830f9 commit 5717606707c4bdae7710dc382b3f687e713830f9 Author: eugenebut <eugenebut@chromium.org> Date: Fri Apr 07 17:21:54 2017 Removed CRWWebControllerInvalidUrlTest.LoadInvalidURL. This test executes code path which is not used in the real app and hence is not useful. BUG= 709290 Review-Url: https://codereview.chromium.org/2802163002 Cr-Commit-Position: refs/heads/master@{#462907} [modify] https://crrev.com/5717606707c4bdae7710dc382b3f687e713830f9/ios/web/web_state/ui/crw_web_controller_unittest.mm
,
Apr 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, Apr 7 2017