Setting chrome_rev in chromite recipe is overly complicated. |
|||||||||||||
Issue descriptionSetting --chrome_rev in the chromite recipe is the last behavior that requires the recipe to parse the ChromeOS configuration file. Since there is a configuration setting for this value, it seems easiest to just move it into the config, though that config change will require merging back to all active branches.
,
Apr 7 2017
After discussion with Bernie, the plan is to land my fix on TOT (where it has no effect), merge to R58 watch a few builds, then merge everywhere. After it's fully rolled out, I'll retry to land my recipe change that depends on this.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ec71d62b63764cd5b483dfd9641cf38d0e27567e commit ec71d62b63764cd5b483dfd9641cf38d0e27567e Author: Don Garrett <dgarrett@google.com> Date: Fri Apr 07 05:27:03 2017 chromeos_config: Specify chrome_rev in pre-flight-branch. We have been specifying the chrome_rev option on the command line via a recipe configuration. Doing it in the build config like everything else is much easier to mainatin. After this is landed, and merged out to active branches, I'll remove the recipe configuration. BUG= chromium:709287 TEST=Unittests. Change-Id: Ia2b0b6f735eadae988f6edb9aad866f8c4d340d5 Reviewed-on: https://chromium-review.googlesource.com/470706 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/ec71d62b63764cd5b483dfd9641cf38d0e27567e/cbuildbot/config_dump.json [modify] https://crrev.com/ec71d62b63764cd5b483dfd9641cf38d0e27567e/cbuildbot/chromeos_config.py
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ec71d62b63764cd5b483dfd9641cf38d0e27567e commit ec71d62b63764cd5b483dfd9641cf38d0e27567e Author: Don Garrett <dgarrett@google.com> Date: Fri Apr 07 05:27:03 2017 chromeos_config: Specify chrome_rev in pre-flight-branch. We have been specifying the chrome_rev option on the command line via a recipe configuration. Doing it in the build config like everything else is much easier to mainatin. After this is landed, and merged out to active branches, I'll remove the recipe configuration. BUG= chromium:709287 TEST=Unittests. Change-Id: Ia2b0b6f735eadae988f6edb9aad866f8c4d340d5 Reviewed-on: https://chromium-review.googlesource.com/470706 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/ec71d62b63764cd5b483dfd9641cf38d0e27567e/cbuildbot/config_dump.json [modify] https://crrev.com/ec71d62b63764cd5b483dfd9641cf38d0e27567e/cbuildbot/chromeos_config.py
,
Apr 7 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f58e59955d033b937a0b70165858ba0df0adf81a commit f58e59955d033b937a0b70165858ba0df0adf81a Author: Don Garrett <dgarrett@google.com> Date: Fri Apr 07 19:05:47 2017 chromeos_config: Specify chrome_rev in pre-flight-branch. We have been specifying the chrome_rev option on the command line via a recipe configuration. Doing it in the build config like everything else is much easier to mainatin. After this is landed, and merged out to active branches, I'll remove the recipe configuration. BUG= chromium:709287 TEST=Unittests. Change-Id: Ia2b0b6f735eadae988f6edb9aad866f8c4d340d5 Reviewed-on: https://chromium-review.googlesource.com/470706 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> (cherry picked from commit ec71d62b63764cd5b483dfd9641cf38d0e27567e) Reviewed-on: https://chromium-review.googlesource.com/471807 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/f58e59955d033b937a0b70165858ba0df0adf81a/cbuildbot/config_dump.json [modify] https://crrev.com/f58e59955d033b937a0b70165858ba0df0adf81a/cbuildbot/chromeos_config.py
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f58e59955d033b937a0b70165858ba0df0adf81a commit f58e59955d033b937a0b70165858ba0df0adf81a Author: Don Garrett <dgarrett@google.com> Date: Fri Apr 07 19:05:47 2017 chromeos_config: Specify chrome_rev in pre-flight-branch. We have been specifying the chrome_rev option on the command line via a recipe configuration. Doing it in the build config like everything else is much easier to mainatin. After this is landed, and merged out to active branches, I'll remove the recipe configuration. BUG= chromium:709287 TEST=Unittests. Change-Id: Ia2b0b6f735eadae988f6edb9aad866f8c4d340d5 Reviewed-on: https://chromium-review.googlesource.com/470706 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> (cherry picked from commit ec71d62b63764cd5b483dfd9641cf38d0e27567e) Reviewed-on: https://chromium-review.googlesource.com/471807 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/f58e59955d033b937a0b70165858ba0df0adf81a/cbuildbot/config_dump.json [modify] https://crrev.com/f58e59955d033b937a0b70165858ba0df0adf81a/cbuildbot/chromeos_config.py
,
Apr 8 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 10 2017
,
Apr 10 2017
56 is dead, and 57 has shipped its final stable, but as this is a build side change it should be ok.
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/74196f1b99b663c5b03ed61c3b8e6ab938f946a3 commit 74196f1b99b663c5b03ed61c3b8e6ab938f946a3 Author: Don Garrett <dgarrett@google.com> Date: Mon Apr 10 23:26:34 2017 chromeos_config: Specify chrome_rev in pre-flight-branch. We have been specifying the chrome_rev option on the command line via a recipe configuration. Doing it in the build config like everything else is much easier to mainatin. After this is landed, and merged out to active branches, I'll remove the recipe configuration. BUG= chromium:709287 TEST=Unittests. Change-Id: Ia2b0b6f735eadae988f6edb9aad866f8c4d340d5 Reviewed-on: https://chromium-review.googlesource.com/470706 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org> (cherry picked from commit ec71d62b63764cd5b483dfd9641cf38d0e27567e) Reviewed-on: https://chromium-review.googlesource.com/474047 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/74196f1b99b663c5b03ed61c3b8e6ab938f946a3/cbuildbot/config_dump.json [modify] https://crrev.com/74196f1b99b663c5b03ed61c3b8e6ab938f946a3/cbuildbot/chromeos_config.py
,
Apr 10 2017
The R56 change does not cherry-pick cleanly. Since it's not important, I'm going to skip that merge. If it becomes important, I'll help resolve it.
,
Apr 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e056c4fb04a74cf4e2751c3f96d15da6ee02b7a7 commit e056c4fb04a74cf4e2751c3f96d15da6ee02b7a7 Author: Don Garrett <dgarrett@google.com> Date: Tue Apr 11 01:02:44 2017
,
Apr 11 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 11 2017
,
Apr 11 2017
The recipe change to remove the --chrome_rev command line option is in place. Assuming that overnight builds worked correctly, this is fixed!
,
Apr 13 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by dgarr...@chromium.org
, Apr 6 2017