New issue
Advanced search Search tips

Issue 709274 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

load_library_perf_tests failing on chromium.perf/Linux Perf

Project Member Reported by martiniss@chromium.org, Apr 6 2017

Issue description

load_library_perf_tests failing on chromium.perf/Linux Perf

Builders failed on: 
- Linux Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf


The logs say absolutely nothing; all I know is it failed now, and passed before. 

https://uberchromegw.corp.google.com/i/chromium.perf/builders/Linux%20Perf/builds/535 is the first build where it fails. I'll start a bisect.
 
Owner: hmchen@chromium.org
Could be related to https://codereview.chromium.org/2792743002

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : load_library_perf_tests
  Metric       : time_to_load_library/libclearkeycdm.so

Revision             Exit Code      N
chromium@462010      0 +- N/A       20      good
chromium@462114      0 +- N/A       20      bad

To Run This Test
  ./src/out/Release/load_library_perf_tests --single-process-tests

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983020297955406432

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4941325104840704


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
That CL is listed in the blamelist.

Looks like bisect didn't work? :/ I reported it.

Comment 5 by xhw...@chromium.org, Apr 10 2017

Cc: crouleau@google.com
 Issue 710010  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7c900592f9b768b8f5f490fb450b84b0b3fe26

commit 1a7c900592f9b768b8f5f490fb450b84b0b3fe26
Author: Annie Sullivan <sullivan@chromium.org>
Date: Thu Apr 27 00:11:29 2017

Disable failing load_library_perf_tests on linux.

BUG= 709274 

Change-Id: I1557267de99e9f2fb82a3a26f24553fcc1e02a24
Reviewed-on: https://chromium-review.googlesource.com/487870
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#467523}
[modify] https://crrev.com/1a7c900592f9b768b8f5f490fb450b84b0b3fe26/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/1a7c900592f9b768b8f5f490fb450b84b0b3fe26/tools/perf/benchmark.csv
[modify] https://crrev.com/1a7c900592f9b768b8f5f490fb450b84b0b3fe26/tools/perf/core/perf_data_generator.py

Comment 7 by xhw...@chromium.org, May 18 2017

Status: Assigned (was: Available)
After we check-in the new CDM and revert https://codereview.chromium.org/2792743002, we should be able to re-enable these tests.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2989b06c3f52e0ea88633002fac9b87905ba43d3

commit 2989b06c3f52e0ea88633002fac9b87905ba43d3
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Fri Jun 09 18:46:46 2017

Revert "Disable failing load_library_perf_tests on linux."

This reverts commit 1a7c900592f9b768b8f5f490fb450b84b0b3fe26.

Reason for revert: The original offending CL has already been reverted. See https://codereview.chromium.org/2893853003/

Original change's description:
> Disable failing load_library_perf_tests on linux.
> 
> BUG= 709274 
> 
> Change-Id: I1557267de99e9f2fb82a3a26f24553fcc1e02a24
> Reviewed-on: https://chromium-review.googlesource.com/487870
> Commit-Queue: Annie Sullivan <sullivan@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#467523}

TBR=sullivan@chromium.org,nednguyen@google.com,martiniss@chromium.org,ashleymarie@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG= 709274 

Change-Id: Icd2288201d0a49be9b01ae3167adb727c67adf92
Reviewed-on: https://chromium-review.googlesource.com/522235
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478350}
[modify] https://crrev.com/2989b06c3f52e0ea88633002fac9b87905ba43d3/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/2989b06c3f52e0ea88633002fac9b87905ba43d3/tools/perf/core/perf_data_generator.py

Cc: -xhw...@chromium.org hmchen@chromium.org
Owner: xhw...@chromium.org
Status: Started (was: Assigned)
The revert is landed. I'll watch the bot to see whether everything is working as expected.

Sign in to add a comment