New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709269 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Determine layer's draw blend mode without relying on layer owning a render surface

Project Member Reported by jaydasika@chromium.org, Apr 6 2017

Issue description

cc::Layer and cc::LayerImpl's draw_blend_mode depends on whether the layer created a render surface. Since we are moving away from layers owning render surfaces, this has to change.
 
Does blend mode creating a render surface always happen with isolation group? Can we just make isolation group creating effect node instead of a layer?

Or is it possible to basically say ignore the blend mode on layer if their target shares the same blend mode as the layer?
Actually, I just realized layer's draw blend mode is always set to the default (SkBlendMode::kSrcOver). Whenever we have a non-default blend mode, we create a render surface and the surface does the blending.
So, we can just delete LayerImpl::draw_blend_mode as its always the default. 
Owner: jaydasika@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment