Update OOBE Illustrations - eng tracking |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Issue descriptionInclude new illustrations in OOBE per https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZfSHzqDNTRuU/files/MCEQOjw4azeHxD2udjHl2CK5wMSJbxAVNpw Looks like Powerwash is tracked in crbug/653269 and Network Error screen in crbug/689198, so this is to tracking "Connecting to network" and "Updating" screens. Additionally, at some point we'd like to turn these illustrations into short animations, so adding them in a way that will make that easier down the road is good for us.
,
Apr 11 2017
Zach, the first link does not match [this is to tracking "Connecting to network" and "Updating" screens].
,
Apr 11 2017
Oops, how's this one: https://folio.googleplex.com/cros-oobe-main-flow#
,
Apr 11 2017
Hi Alex! Here are the screens that needs illustration. Let me know if you have any questions.
,
May 14 2017
Alexander were you able to do these or should I punt to 61?
,
May 23 2017
Punting to 61
,
Aug 3 2017
Where can I get Update Screen illustration? I could not find it in https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2OMkR0OHUzbnB3UWs .
,
Aug 10 2017
+Zach
,
Aug 10 2017
All the updated illustrations are here: https://drive.google.com/open?id=0B_2Uyb2Rhx2OMkR0OHUzbnB3UWs
,
Aug 12 2017
I attached screenshots of the update screen with the new illustration. Illustration is aligned 10 pixels from the bottom of the dialog to prevent it from moving when dialog content is updated. On the last screenshot it is only 2 pixels from the "Finalizing" label, so I cannot move it up.
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20c6ee8c1141b0ad1c9739e11e8f2ba151004a11 commit 20c6ee8c1141b0ad1c9739e11e8f2ba151004a11 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Aug 12 05:26:08 2017 ChromeOS OOBE: add illustration for the update screen. Bug: 709256 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4cbfbf2766b659885403857ff08d7b11d7df142d Reviewed-on: https://chromium-review.googlesource.com/612742 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#493958} [add] https://crrev.com/20c6ee8c1141b0ad1c9739e11e8f2ba151004a11/chrome/browser/resources/chromeos/login/images/1x/updating_1x.png [add] https://crrev.com/20c6ee8c1141b0ad1c9739e11e8f2ba151004a11/chrome/browser/resources/chromeos/login/images/2x/updating_2x.png [modify] https://crrev.com/20c6ee8c1141b0ad1c9739e11e8f2ba151004a11/chrome/browser/resources/chromeos/login/oobe_update.css [modify] https://crrev.com/20c6ee8c1141b0ad1c9739e11e8f2ba151004a11/chrome/browser/resources/chromeos/login/oobe_update.html
,
Aug 16 2017
,
Aug 16 2017
,
Aug 16 2017
Issue 755711 has been merged into this issue.
,
Aug 16 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16 2017
Approving merge to M61 Chrome OS.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b602e71722ac36f17d28d01fe29d4047b482b48f commit b602e71722ac36f17d28d01fe29d4047b482b48f Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Aug 16 22:55:15 2017 ChromeOS OOBE: add illustration for the update screen. TBR=alemate@chromium.org (cherry picked from commit 20c6ee8c1141b0ad1c9739e11e8f2ba151004a11) Bug: 709256 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4cbfbf2766b659885403857ff08d7b11d7df142d Reviewed-on: https://chromium-review.googlesource.com/612742 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493958} Reviewed-on: https://chromium-review.googlesource.com/617659 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#613} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [add] https://crrev.com/b602e71722ac36f17d28d01fe29d4047b482b48f/chrome/browser/resources/chromeos/login/images/1x/updating_1x.png [add] https://crrev.com/b602e71722ac36f17d28d01fe29d4047b482b48f/chrome/browser/resources/chromeos/login/images/2x/updating_2x.png [modify] https://crrev.com/b602e71722ac36f17d28d01fe29d4047b482b48f/chrome/browser/resources/chromeos/login/oobe_update.css [modify] https://crrev.com/b602e71722ac36f17d28d01fe29d4047b482b48f/chrome/browser/resources/chromeos/login/oobe_update.html
,
Aug 17 2017
Could we remove the moon from the illustration to make it shorter, aligning the people more closely to the original spec?
,
Aug 17 2017
I readjust the size of the illustrations here: https://drive.google.com/open?id=0B_2Uyb2Rhx2OMkR0OHUzbnB3UWs Please refer to the attached mocks to fix the spacing and alignment issues.
,
Aug 22 2017
Did you get the chance to make the changes? Please let me know if you have any questions. The illustrations are too low on the screen still.
,
Aug 24 2017
alemate@ could you make adjustments per #19 and #20?
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70252685371fea1e48bfad02c1ebf69718d30872 commit 70252685371fea1e48bfad02c1ebf69718d30872 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Aug 26 03:09:21 2017 Chrome OS OOBE: Adjust layout of Update screen after review. Bug: 709256 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I606c6decb8d5fa816614f628311ab13475f30bdc Reviewed-on: https://chromium-review.googlesource.com/636318 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#497645} [modify] https://crrev.com/70252685371fea1e48bfad02c1ebf69718d30872/chrome/browser/resources/chromeos/login/images/1x/updating_1x.png [modify] https://crrev.com/70252685371fea1e48bfad02c1ebf69718d30872/chrome/browser/resources/chromeos/login/images/2x/updating_2x.png [modify] https://crrev.com/70252685371fea1e48bfad02c1ebf69718d30872/chrome/browser/resources/chromeos/login/oobe_update.css [modify] https://crrev.com/70252685371fea1e48bfad02c1ebf69718d30872/chrome/browser/resources/chromeos/login/oobe_update.html
,
Aug 26 2017
,
Aug 26 2017
This bug requires manual review: We are only 9 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 26 2017
I filed another new issue 759274 to update text, because it is tricky. Let's merge illustration and layout changes only to M61.
,
Aug 28 2017
Sounds good, thanks Alexander!
,
Aug 28 2017
Approving merge for M61.
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d2b592ff57a52787adfc82df302babd6ebd9967 commit 7d2b592ff57a52787adfc82df302babd6ebd9967 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Aug 28 23:35:12 2017 Chrome OS OOBE: Adjust layout of Update screen after review. TBR=alemate@chromium.org (cherry picked from commit 70252685371fea1e48bfad02c1ebf69718d30872) Bug: 709256 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I606c6decb8d5fa816614f628311ab13475f30bdc Reviewed-on: https://chromium-review.googlesource.com/636318 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#497645} Reviewed-on: https://chromium-review.googlesource.com/639575 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#958} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/7d2b592ff57a52787adfc82df302babd6ebd9967/chrome/browser/resources/chromeos/login/images/1x/updating_1x.png [modify] https://crrev.com/7d2b592ff57a52787adfc82df302babd6ebd9967/chrome/browser/resources/chromeos/login/images/2x/updating_2x.png [modify] https://crrev.com/7d2b592ff57a52787adfc82df302babd6ebd9967/chrome/browser/resources/chromeos/login/oobe_update.css [modify] https://crrev.com/7d2b592ff57a52787adfc82df302babd6ebd9967/chrome/browser/resources/chromeos/login/oobe_update.html
,
Aug 31 2017
Here is an updated UI.
,
Aug 31 2017
Thanks Alexander! LGTM.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdc097a7a4e9d92d98915ff9b503f385a69c73e1 commit cdc097a7a4e9d92d98915ff9b503f385a69c73e1 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Aug 31 21:27:51 2017 Chrome OS OOBE: Adjust Update screen after UI review. Bug: 709256 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia5c4fbdd5d02780b0f846dbe23f6cb0943059d6f Reviewed-on: https://chromium-review.googlesource.com/645166 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#499006} [modify] https://crrev.com/cdc097a7a4e9d92d98915ff9b503f385a69c73e1/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/cdc097a7a4e9d92d98915ff9b503f385a69c73e1/chrome/browser/resources/chromeos/login/oobe_screen_update.html [modify] https://crrev.com/cdc097a7a4e9d92d98915ff9b503f385a69c73e1/chrome/browser/resources/chromeos/login/oobe_screen_update.js [modify] https://crrev.com/cdc097a7a4e9d92d98915ff9b503f385a69c73e1/chrome/browser/resources/chromeos/login/oobe_update.css [modify] https://crrev.com/cdc097a7a4e9d92d98915ff9b503f385a69c73e1/chrome/browser/resources/chromeos/login/oobe_update.html [modify] https://crrev.com/cdc097a7a4e9d92d98915ff9b503f385a69c73e1/chrome/browser/resources/chromeos/login/oobe_update.js [modify] https://crrev.com/cdc097a7a4e9d92d98915ff9b503f385a69c73e1/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
,
Aug 31 2017
,
Aug 31 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 1 2017
Alex, can you send us the screenshots for review?
,
Sep 1 2017
See comment #30 above ( https://crbug.com/709256#c30 ).
,
Sep 1 2017
Approved merge to M61.
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/959058f27ac13a38fa7decc381ee5bc71164801c commit 959058f27ac13a38fa7decc381ee5bc71164801c Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Sep 01 23:40:22 2017 Chrome OS OOBE: Adjust Update screen after UI review. TBR=alemate@chromium.org (cherry picked from commit cdc097a7a4e9d92d98915ff9b503f385a69c73e1) Bug: 709256 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia5c4fbdd5d02780b0f846dbe23f6cb0943059d6f Reviewed-on: https://chromium-review.googlesource.com/645166 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499006} Reviewed-on: https://chromium-review.googlesource.com/648264 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1082} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/959058f27ac13a38fa7decc381ee5bc71164801c/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/959058f27ac13a38fa7decc381ee5bc71164801c/chrome/browser/resources/chromeos/login/oobe_screen_update.html [modify] https://crrev.com/959058f27ac13a38fa7decc381ee5bc71164801c/chrome/browser/resources/chromeos/login/oobe_screen_update.js [modify] https://crrev.com/959058f27ac13a38fa7decc381ee5bc71164801c/chrome/browser/resources/chromeos/login/oobe_update.css [modify] https://crrev.com/959058f27ac13a38fa7decc381ee5bc71164801c/chrome/browser/resources/chromeos/login/oobe_update.html [modify] https://crrev.com/959058f27ac13a38fa7decc381ee5bc71164801c/chrome/browser/resources/chromeos/login/oobe_update.js [modify] https://crrev.com/959058f27ac13a38fa7decc381ee5bc71164801c/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by elizabethchiu@chromium.org
, Apr 7 2017