Issue metadata
Sign in to add a comment
|
Pulling up Chrome Chrome Home does not move more of the origin into view if there is a sufficiently long path |
||||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3063.0 OS: Android 7.1.1 What steps will reproduce the problem? (1) Enable Chrome Home (2) Load a URL with a path of at least a few characters (3) Pull the omnibox up. What is the expected result? The URL moves to the right, so that the end of the origin is aligned with the omnibox. (path-pulled.png) What happens instead? The URL keeps its left alignment and shows more of the path. It seems Chrome Home triggers is at least some logic for moving the origin around to fit in the omnibox: see no-path-unpulled.png and no-path-pulled.png Per Enamel guidelines, we should show as much of the origin as possible, elided from the left (i.e. right-aligned with the right of the omnibox if it's overflowing). See origins.png, from https://www.chromium.org/Home/chromium-security/enamel#TOC-Eliding-Origin-Names-And-Hostnames ktam@, could you triage?
,
Apr 6 2017
,
Jun 21 2017
We didn't (intentionally) change anything related to this for Chrome Home. Is there someone security/enamel team who would be suited to help us investigate?
,
Jun 21 2017
The issue is that Chrome Home dynamically removes the tab and overflow icons if you pull up, without telling the eliding code to realign the URL. You'll need to hook that up for when the icons are added/removed.
,
Jul 11 2017
Marking as available for an engineer to take a look.
,
Jul 11 2017
lgarron@ - where does the eliding coded reside? I'm not familiar with the URL sliding we do for security, but may be able to take a stab at this with some pointers.
,
Jul 11 2017
I believe this is handled by scrollToTLD() https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java?l=629
,
Jul 20 2017
,
Jul 26 2017
Attached are pictures that show the fixed behavior. I believe cases where this doesn't work are related to the bug mentioned earlier (https://bugs.chromium.org/p/chromium/issues/detail?id=705778).
,
Aug 10 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c commit c66796aceaf9fb04d15aca43ff0c30de63dd4d5c Author: danielpark@chromium.org <danielpark@chromium.org> Date: Mon Aug 14 20:17:52 2017 [Home] Scroll URL to ensure TLD visible when opening/closing sheet Adds public #getUrlBar() to LocationBarLayout.java. Calls the new method + urlbar's #scrollToTLD() method at animationEnd of BottomToolbarPhone's CancelAwareAnimatorListener. Bug: 709238 Change-Id: Ic989c4d172827a4921fd50aa087812d656d19c53 Reviewed-on: https://chromium-review.googlesource.com/586433 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#494162} [modify] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
,
Aug 21 2017
danielpark@, can this bug be marked as "Fixed"?
,
Aug 21 2017
,
Aug 22 2017
Works as per expected behavior provided in the screenshots @ Comment#9. Verified in 62.0.3193.0. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Apr 6 2017