New issue
Advanced search Search tips

Issue 709227 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
qyears...@chromium.org
jeffcarp@chromium.org
jsb...@chromium.org
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Triage new WPT failures from adding .any.js tests

Project Member Reported by jeffcarp@chromium.org, Apr 6 2017 
These were added in https://chromium-review.googlesource.com/c/461722/

external/wpt/background-fetch/interfaces.worker.html [ Skip ]
external/wpt/user-timing/invoke_with_timing_attributes.worker.html [ Skip ]
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/affb7beef0c025000f33c5a0f9f3afed37b2c3f6

commit affb7beef0c025000f33c5a0f9f3afed37b2c3f6
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Tue Aug 15 08:56:58 2017

LayoutTests: Disabling flaky generatekey tests.

BUG=709227,626703
TBR=qyearsley@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: I5beef832db68b5660f2c1f948abc9dd012ebd552
Reviewed-on: https://chromium-review.googlesource.com/615280
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494346}
[modify] https://crrev.com/affb7beef0c025000f33c5a0f9f3afed37b2c3f6/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89a384d2fe7afa6d9fc5fbbb01c1a6294da5db78

commit 89a384d2fe7afa6d9fc5fbbb01c1a6294da5db78
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Thu Aug 17 01:24:21 2017

LayoutTests: Disabling flaky html5lib_tests16.html

BUG=709227
TBR=qyearsley@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: I4fd37a39ed4a25692261933d2cf14393e1c33595
Reviewed-on: https://chromium-review.googlesource.com/618182
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495033}
[modify] https://crrev.com/89a384d2fe7afa6d9fc5fbbb01c1a6294da5db78/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44c2aec5bbd487a98728635f32e8f3c3d6935768

commit 44c2aec5bbd487a98728635f32e8f3c3d6935768
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Tue Aug 22 03:36:15 2017

LayoutTests: Disabling WebCryptoAPI tests imported for wpt.

These tests are flaky on Mac / Windows and are failing everywhere.

BUG=655458, 721814 , 757698 ,709227
TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: Ia0ae3d6ee71751bf667c110e732c557309c21737
Reviewed-on: https://chromium-review.googlesource.com/624770
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496200}
[modify] https://crrev.com/44c2aec5bbd487a98728635f32e8f3c3d6935768/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48bdfc57f7a71076ae35788dd18b27d3c8439a9f

commit 48bdfc57f7a71076ae35788dd18b27d3c8439a9f
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Tue Aug 22 08:32:46 2017

LayoutTests: Disable WebCryptoAPI missed from last CL.

XXX.worker.html verse XXX.https.html

Failures -> https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/61159

BUG=655458, 721814 , 757698 ,709227
TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: I3cf8864d8a5c8af379322b25298e0e7ebdc6b356
Reviewed-on: https://chromium-review.googlesource.com/625638
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496251}
[modify] https://crrev.com/48bdfc57f7a71076ae35788dd18b27d3c8439a9f/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a581405cdb71ba301a6694c03c90ba730541816d

commit a581405cdb71ba301a6694c03c90ba730541816d
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Aug 22 10:31:40 2017

Fix incorrect paths in WebCrpytoAPI TestExpectations

BUG=655458, 721814 , 757698 ,709227
TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
NOTRY=true

Change-Id: I05c9db91a8e104d871c1f82aec6129066518259a
Reviewed-on: https://chromium-review.googlesource.com/625517
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496271}
[modify] https://crrev.com/a581405cdb71ba301a6694c03c90ba730541816d/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e0702f4f6561a8fd1eec1684c8cda906576091

commit b9e0702f4f6561a8fd1eec1684c8cda906576091
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Aug 22 11:20:48 2017

Revert "Fix incorrect paths in WebCrpytoAPI TestExpectations"

This reverts commit a581405cdb71ba301a6694c03c90ba730541816d.

Reason for revert: Might have accidentally added/removed tests, and we want to Skip some of these, not Pass/Failure.

Original change's description:
> Fix incorrect paths in WebCrpytoAPI TestExpectations
> 
> BUG=655458, 721814 , 757698 ,709227
> TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org
> NOTRY=true
> 
> Change-Id: I05c9db91a8e104d871c1f82aec6129066518259a
> Reviewed-on: https://chromium-review.googlesource.com/625517
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496271}

TBR=hbos@chromium.org

Change-Id: Id3c86fc509f644fdc3bc6a196650c1c3cd157fa9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 655458,  721814 ,  757698 , 709227
Reviewed-on: https://chromium-review.googlesource.com/625996
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496279}
[modify] https://crrev.com/b9e0702f4f6561a8fd1eec1684c8cda906576091/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4475941a1f908b61441c374e60a2f75dbdce8b5

commit f4475941a1f908b61441c374e60a2f75dbdce8b5
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Dec 12 18:16:17 2017

Remove po-callback from TestExpectations

The tests po-callback-mutate seem to always pass now. Fixed by commit
7df7884ee789a33cd850c04d6d462aaacb6df9f0

Bug: 709227
Change-Id: Id80041ca02d1dd6d2bd84d75096afeeb00b7755a
Reviewed-on: https://chromium-review.googlesource.com/820852
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523477}
[modify] https://crrev.com/f4475941a1f908b61441c374e60a2f75dbdce8b5/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by robertma@chromium.org, Dec 20 2017 

Many of the tests linked to this umbrella bug can be rebaselined and are not flaky. Shall we do that and remove the expectation lines?

Comment 9 by robertma@chromium.org, Dec 20 2017

Cc: robertma@chromium.org
Components: Blink>Infra>Ecosystem

Comment 10 by jeffcarp@chromium.org, Jan 3 2018

Cc: jeffcarp@chromium.org
Owner: ----
Status: Available (was: Assigned)
Removing the lines & rebaselining sounds like a good plan. Removing myself as owner since I unfortunately don't have the bandwidth to close the loop on this.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/896f7ee392f96a9a8c4ada662e1071f630490013

commit 896f7ee392f96a9a8c4ada662e1071f630490013
Author: clamy <clamy@chromium.org>
Date: Wed Jan 10 18:23:26 2018

Update test expectations of flaky layout_test

This CL updates the test expecations for
external/wpt/websockets/opening-handshake/003.html?wss which is supposed
to fail but also times out on mac_chromium_rel_ng.

TBR=jeffcarp@chromium.org

Bug:  800509 ,709227
Change-Id: Ia74690f6d53c63ff50312aed0f81c3a08f6d216b
Reviewed-on: https://chromium-review.googlesource.com/860360
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528361}
[modify] https://crrev.com/896f7ee392f96a9a8c4ada662e1071f630490013/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01b5e14bfd1f1f948b294db5f7f486f276a157d0

commit 01b5e14bfd1f1f948b294db5f7f486f276a157d0
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Jan 12 14:40:33 2018

Expect timeouts for hkdf.https.worker.html

This test failed (as of this writing) 3 out of 5 times due to timeouts
on Linux MSAN. Before the renaming by the upstream, this test has been
known to fail and was previously makes as Failing (therefore adding the other attributes).

TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org

Bug:  801498 ,709227
Change-Id: I155e144db6689d93ca07b1b098bdf21c2f116abe
Reviewed-on: https://chromium-review.googlesource.com/863885
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528941}
[modify] https://crrev.com/01b5e14bfd1f1f948b294db5f7f486f276a157d0/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeccc449b06473ee8ada7f13e098abff44b00c71

commit aeccc449b06473ee8ada7f13e098abff44b00c71
Author: Robert Ma <robertma@chromium.org>
Date: Fri Jan 12 19:32:54 2018

Adjust expectations for WebCryptoAPI after the rename is imported

1. Remove a bunch of renamed tests.
2. Move all remaining WebCryptoAPI together and change the bug links.

TBR=fhorschig

Bug: 801357, 709227
Change-Id: If24d8a8dd4adabbbd55967950db2874bf2e9d965
Reviewed-on: https://chromium-review.googlesource.com/864844
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529020}
[modify] https://crrev.com/aeccc449b06473ee8ada7f13e098abff44b00c71/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/901dfc8c50721bc2fa7a4513b21e685894655539

commit 901dfc8c50721bc2fa7a4513b21e685894655539
Author: Robert Ma <robertma@chromium.org>
Date: Thu Jan 18 21:53:19 2018

Rebaseline tests with query strings in the names

Apart from a few timed out tests, one test has non-deterministic output, and
the other is pass-failure flaky.

Bug: 800570, 709227,  803200 , 803558
Change-Id: I86d5a14f26fcab6b862cd2e1b2108c10db4ee94e
Reviewed-on: https://chromium-review.googlesource.com/871138
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530284}
[modify] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_menuitem-element_run_type=uri-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_menuitem-element_run_type=write-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_menuitem-element_run_type=write_single-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_template_run_type=uri-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_template_run_type=write-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_template_run_type=write_single-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests11_run_type=uri-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests11_run_type=write-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests11_run_type=write_single-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests25_run_type=uri-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests25_run_type=write-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests25_run_type=write_single-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_webkit02_run_type=uri-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_webkit02_run_type=write-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_webkit02_run_type=write_single-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/constructor/002-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/constructor/002_wss-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/cookies/007-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/cookies/007_wss-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/interfaces/WebSocket/close/close-connecting-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/interfaces/WebSocket/close/close-connecting_wss-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/interfaces/WebSocket/close/close-nested-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/interfaces/WebSocket/close/close-nested_wss-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/interfaces/WebSocket/readyState/003-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/interfaces/WebSocket/readyState/003_wss-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/unload-a-document/002-expected.txt
[add] https://crrev.com/901dfc8c50721bc2fa7a4513b21e685894655539/third_party/WebKit/LayoutTests/external/wpt/websockets/unload-a-document/002_wss-expected.txt

Comment 15 by robertma@chromium.org, Jan 18 2018

Cc: jsb...@chromium.org
 Issue 748723  has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7924704901550e16796e3f9946c89b30436d6544

commit 7924704901550e16796e3f9946c89b30436d6544
Author: Peter Mayo <petermayo@chromium.org>
Date: Mon Jul 16 17:32:07 2018

Update WPT Expectation 2d.pattern.basic.nocontext

external/wpt/offscreen-canvas/fill-and-stroke-styles/
2d.pattern.basic.nocontext.worker.html
was disabled as crashing when the .any.js tests were added,
but is now unexpectedly just failing.

Highly likely that some fix in the last year and a half has
rendered this less broken.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#
    testType=webkit_layout_tests&
    tests=2d.pattern.basic.nocontext.worker.html

and trybots for previous patchsets for reference and examples of the
various behaviors. Notably, the test crashes (fails a DCHECK) on CQ
and some debug bots. (Un)fortunately, the expectations language can't
express the variance in this test's expectation.  Each bot type in
itself tends to be consistent.

Bug: 709227
Change-Id: I6522468d656fd6a4dfcb56af9ce05a11e9bc9aa4
Reviewed-on: https://chromium-review.googlesource.com/1134022
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575329}
[modify] https://crrev.com/7924704901550e16796e3f9946c89b30436d6544/third_party/WebKit/LayoutTests/TestExpectations
►

Sign in to add a comment