mushrome: Fix exo WMHelperAsh usage of ui::DeviceDataManager |
||||
Issue descriptionUnder mushrome there's no ui::DeviceDataManager but WMHelperAsh uses one to detect keyboard configuration changes. I'm not familiar enough with DDM to know what the right solution is here.
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/807942831018b22765df0b45bbd0d0d7deec27c1 commit 807942831018b22765df0b45bbd0d0d7deec27c1 Author: penghuang <penghuang@chromium.org> Date: Wed Apr 26 21:49:37 2017 Mushrome: Use ui::InputDeviceManager in exo. The ui::InputDeviceManager implementation ui::DeviceDataManager is not available in Mushrome, but another implementation ui::InputDeviceClient is avaliable in Mushrome. So we should use ui::InputDeviceManager::GetInstance() which will return correct implementation for Cash and Mushrome instead of using ui::DeviceDataManager::GetInstance(). BUG= 709225 Review-Url: https://codereview.chromium.org/2840193004 Cr-Commit-Position: refs/heads/master@{#467469} [modify] https://crrev.com/807942831018b22765df0b45bbd0d0d7deec27c1/components/exo/wm_helper_ash.cc
,
Apr 27 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by penghuang@chromium.org
, Apr 26 2017Owner: penghuang@chromium.org
Status: Assigned (was: Untriaged)