All chromium-sheriffed builders should have matching try bots |
|||||||||
Issue description
We want to ensure that if a CL needs to be reverted because it is breaking a builder, then the CL's owner can try the patch against a tryserver to figure out why it broke.
Ideally, this doesn't even really come up because every waterfall builder should have a matching tryserver in the CQ, but we don't currently enforce that and aren't likely to in the forseeable future.
So, we should at least make sure there are *optional* trybots for every waterfall builder. We can start by ensuring that there are optional trybots for every *sheriffed* waterfall builder, since people who own unsheriffed builders are usually responsible for fixing breakages rather than reverting CLs.
Of course, some of the sheriffed waterfalls are harder to mirror than others (e.g., the perf builders, which might have specialized hardware, and the fyi waterfall), so let's start with the builders on the main chromium waterfalls: chromium and
chromium.{android,chrome,chromiumos,gpu,linux,mac,memory,webkit,win}.
Fortunately, we actually already have the list of builders that are missing, and the checks to make sure we don't miss new ones, here:
https://cs.chromium.org/chromium/build/tests/masters_recipes_test.py?l=37
,
Apr 6 2017
Issue 663060 has been merged into this issue.
,
Apr 6 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/e1ea0a6aef053fe91951fe4919b19d91f53d0901 commit e1ea0a6aef053fe91951fe4919b19d91f53d0901 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Apr 07 20:28:49 2017 Add chromium.webkit to masters_recipes_test. We want all of the sheriffed builders to have matching tryservers. masters_recipes_test.py is a test step that checks for this, but it wasn't checking chromium.webkit, so this CL adds those configs. R=phajdan.jr@chromium.org, qyearsley@chromium.org BUG=709214 Change-Id: I109e38b9ebdba5a4f8e642a9ba76d3195d2fa7d8 Reviewed-on: https://chromium-review.googlesource.com/470526 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/e1ea0a6aef053fe91951fe4919b19d91f53d0901/tests/masters_recipes_test.py [modify] https://crrev.com/e1ea0a6aef053fe91951fe4919b19d91f53d0901/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json [modify] https://crrev.com/e1ea0a6aef053fe91951fe4919b19d91f53d0901/scripts/slave/recipe_modules/chromium_tests/trybots.py
,
Apr 27 2017
,
Apr 27 2017
,
May 16 2017
Note: wangxianzhu@ noted that he observed several times when a CL passes the *_chomium_rel_ng bots but breaks the waterfall bots; this would be fixed if the tryserver.blink bots (e.g. mac10.11_blink_rel) were all on the CQ --
Dirk, in theory, do you think we'd have enough capacity to do this now or would we have to wait for layout tests using swarming? Should all CQ bots be on tryserver.chromium.{linux,mac,win} or would it be OK for try bots on tryserver.blink to be CQ bots (after adding many more slaves?)
,
May 16 2017
(Note comment #7 is slightly off-topic for this bug, since I was thinking about adding existing try bots to CQ, rather than adding try bots where none exist yet.)
,
May 17 2017
We should not add the tryserver.blink bots to the CQ in any form. The main linux/win/mac configs are better served by adding the webkit_tests to {linux,mac,win}_chromium_rel_ng. The other OS versions should not be in the CQ at all (at least not until we decide we want coverage for more than 1 os version in the CQ).
We do not yet have the capacity to add either mac or win configurations at the moment, however. We're working on adding more machines now.
,
May 17 2017
We should also not add layout tests until they're swarmed (there's been a number of different discussions about this outlining the reasons not to, but I don't have a link atm)
,
May 25 2017
,
Jul 31 2017
,
Aug 14 2017
,
Jan 30 2018
Issue 733177 has been merged into this issue.
,
Oct 19
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dpranke@chromium.org
, Apr 6 2017Components: Build
Labels: -Pri-3 OS-All Pri-2
Owner: qyears...@chromium.org