Summary: Remove vestigial Context argument from isGoogleSigned & isChromeGoogleSigned (was: Remove vestigial Context argument from isGoogleSigned)
My plan to minimize the number of changes required:
* First change, upstream: add no-Context versions of isGoogleSigned and isChromeGoogleSigned. Make the old isGoogleSigned call the new isGoogleSigned. Make the new isGoogleSigned returns false. This way, the behavior will remain identical in all cases:
- Downstream overrides only the old isGoogleSigned: the override replaces the call to the new isGoogleSigned, so all callers of the old isGoogleSigned get the overridden behavior.
- Downstream overrides only the new isGoogleSigned: the old isGoogleSigned calls the new, overridden isGoogleSigned, so all callers of the old isGoogleSigned get the overridden behavior.
- There is no downstream: isGoogleSigned returns false as usual.
* Second change, downstream: switch isGoogleSigned to override the new version. Switch all downstream callers of isGoogleSigned and isChromeGoogleSigned to the new versions.
* Third change, upstream: remove the old isGoogleSigned and isChromeGoogleSigned. Switch all upstream callers to the new versions.
Comment 1 by paulmiller@chromium.org
, Apr 6 2017