New issue
Advanced search Search tips

Issue 709188 link

Starred by 1 user
Status: Fixed
Owner:
guidou@chromium.org
Closed: Jul 2017
Cc:
m...@chromium.org
mcasas@chromium.org
hta@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Flaky failure in fast/mediastream/MediaStreamTrack-getSettings.html layout test

Project Member Reported by lukasza@chromium.org, Apr 6 2017 
When sheriffing I noticed a flaky failure in fast/mediastream/MediaStreamTrack-getSettings.html - https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/8232

crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: [12709:775:0406/122528.571571:3138084535011:FATAL:media_stream_audio_track.cc(163)] Check failed: format_is_set(). 
STDERR: 0   libbase.dylib                       0x000000010f00d0fe base::debug::StackTrace::StackTrace(unsigned long) + 174
STDERR: 1   libbase.dylib                       0x000000010f00d19d base::debug::StackTrace::StackTrace(unsigned long) + 29
STDERR: 2   libbase.dylib                       0x000000010f00b5fc base::debug::StackTrace::StackTrace() + 28
STDERR: 3   libbase.dylib                       0x000000010f0a5fa0 logging::LogMessage::~LogMessage() + 80
STDERR: 4   libbase.dylib                       0x000000010f0a3aa5 logging::LogMessage::~LogMessage() + 21
STDERR: 5   libcontent.dylib                    0x00000001070fd924 content::MediaStreamAudioTrack::getSettings(blink::WebMediaStreamTrack::Settings&) + 196
STDERR: 6   libblink_platform.dylib             0x000000011a39964e blink::(anonymous namespace)::TrackDataContainer::getSettings(blink::WebMediaStreamTrack::Settings&) + 78
STDERR: 7   libblink_platform.dylib             0x000000011a802b87 blink::MediaStreamComponent::getSettings(blink::WebMediaStreamTrack::Settings&) + 391
STDERR: 8   libblink_modules.dylib              0x00000001252410c2 blink::MediaStreamTrack::getSettings(blink::MediaTrackSettings&) + 98
STDERR: 9   libblink_modules.dylib              0x0000000124931494 blink::MediaStreamTrackV8Internal::getSettingsMethod(v8::FunctionCallbackInfo<v8::Value> const&) + 180
STDERR: 10  libblink_modules.dylib              0x00000001249313d5 blink::V8MediaStreamTrack::getSettingsMethodCallback(v8::FunctionCallbackInfo<v8::Value> const&) + 21
STDERR: 11  libv8.dylib                         0x0000000118c32762 v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) + 450

Comment 1 by lukasza@chromium.org, Apr 6 2017

Cc: m...@chromium.org
Owner: mcasas@chromium.org
mcasas@ / miu@ - I wonder if you could help triage this bug (as content/renderer/media/OWNERS)

Comment 2 by lukasza@chromium.org, Apr 6 2017

Cc: mcasas@chromium.org
Owner: hta@chromium.org
+hta@ - the author of r462523 that has added the failing DCHECK around 3 hours ago

Comment 3 by mcasas@chromium.org, Apr 6 2017

Cc: hta@chromium.org
Components: Blink>MediaStream
Labels: OS-Mac
Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by lukasza@chromium.org, Apr 6 2017 

Hmmm... this failure doesn't seem very flaky right now - the test has failed 3 times in a row on WebKit Mac10.11 (dbg).

Comment 5 by foolip@chromium.org, Apr 7 2017 

I have reverted the CL identified in #2. When sheriffing, when a flaky failure can be tracked down to a recent change, I always revert it even if the flakiness is not severe. This is showing up on sheriff-o-matic right now though.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35aeae1c6f63abb9a4cbb23f497a523349db7aa8

commit 35aeae1c6f63abb9a4cbb23f497a523349db7aa8
Author: foolip <foolip@chromium.org>
Date: Fri Apr 07 06:44:56 2017

Revert of Move getUserMedia finish to "when audio track configured". (patchset #7 id:120001 of https://codereview.chromium.org/2777583002/ )

Reason for revert:
The added DCHECK(format_is_set()) is failing in MediaStreamTrack-getSettings.html

BUG= 709188 

Original issue's description:
> Move getUserMedia finish to "when audio track configured".
>
> Previously, getUserMedia() would complete as soon as the sources
> were initialized - which did not do all the initialization.
> This CL will make getUserMedia() return when the track has been
> told of its configuration through OnSetFormat() from upstream.
>
> This will allow GetSettings() to read the audio configuration from
> the track without worrying about whether the configuration is
> propagated or not.
>
> BUG= 704918 
>
> Review-Url: https://codereview.chromium.org/2777583002
> Cr-Commit-Position: refs/heads/master@{#462523}
> Committed: https://chromium.googlesource.com/chromium/src/+/a52d69d1877b170684041bed04d28acced85e40d

TBR=guidou@chromium.org,hta@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 704918 

Review-Url: https://codereview.chromium.org/2803183002
Cr-Commit-Position: refs/heads/master@{#462797}

[modify] https://crrev.com/35aeae1c6f63abb9a4cbb23f497a523349db7aa8/content/renderer/media/media_stream_audio_source.h
[modify] https://crrev.com/35aeae1c6f63abb9a4cbb23f497a523349db7aa8/content/renderer/media/media_stream_audio_track.cc
[modify] https://crrev.com/35aeae1c6f63abb9a4cbb23f497a523349db7aa8/content/renderer/media/media_stream_audio_track.h
[modify] https://crrev.com/35aeae1c6f63abb9a4cbb23f497a523349db7aa8/content/renderer/media/media_stream_audio_unittest.cc
[modify] https://crrev.com/35aeae1c6f63abb9a4cbb23f497a523349db7aa8/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/35aeae1c6f63abb9a4cbb23f497a523349db7aa8/content/renderer/media/user_media_client_impl_unittest.cc

Comment 7 by guidou@chromium.org, Jul 3 2017

Status: Fixed (was: Assigned)
The revert worked and that funcionality is being reimplemented in a different way.
►

Sign in to add a comment