New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709181 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 905153



Sign in to add a comment

Add support for media capabilities API for MediaRecorder encoding

Project Member Reported by mcasas@chromium.org, Apr 6 2017

Issue description

Following up the PR in [1], add the necessary methods etc to support
MediaCapabilities-like queries for Media Recorder encoding.  

See the DD in [2].

[1] https://github.com/WICG/media-capabilities/pull/31
[2] https://docs.google.com/document/d/1a8zgCshVneckD8ZIsdCO1mTzVfINgQJTQDyFyxQzi7I/edit?ts=58dea745#
 
Related to  https://crbug.com/690380 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9c64a91ffa876438944769b5921d171b5390cc8

commit e9c64a91ffa876438944769b5921d171b5390cc8
Author: mcasas <mcasas@chromium.org>
Date: Wed Apr 12 17:00:27 2017

Media Capabilities: add MediaDecodingConfiguration.idl and update to Spec

This CL shuffles around the idl data structures to match
the current Spec status, namely:
- gets MediaType and |type| out of MediaConfiguration(.idl)
- adds them to a new file MediaDecodingConfiguration(.idl),
 as MediaDecodingType |type|. MediaDecodingConfiguration
 derives from MediaConfiguration.

LayoutTests updated accordingly.

BUG= 709181 ,  690380 

Review-Url: https://codereview.chromium.org/2813133002
Cr-Commit-Position: refs/heads/master@{#464057}

[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness-expected.txt
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness.html
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.h
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaConfiguration.idl
[add] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingConfiguration.idl
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/modules_idl_files.gni

Comment 3 by mcasas@chromium.org, Apr 13 2017

Components: -Blink>Media Blink>Media>Capabilties
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7352cd198a784420184136e78cc14f85ff69c3a

commit f7352cd198a784420184136e78cc14f85ff69c3a
Author: mcasas <mcasas@chromium.org>
Date: Thu Apr 20 23:51:18 2017

Media Capabilities encoding: Blink pass-thru and skeleton renderer/ impl

This CL implements MediaCapabilities.encodingInfo() method,
wiring it for the 'record' type and connecting it to MediaRecorder
canRecordMimeType(). A LayoutTest is also added.

Note that there's no distinction about what codec might be
hardware-accelerated or not yet.

Follows https://github.com/WICG/media-capabilities/pull/36.

DD: http://tinyurl.com/media-capabilities-encoding

BUG= 709181 

Review-Url: https://codereview.chromium.org/2811103006
Cr-Commit-Position: refs/heads/master@{#466191}

[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/content/renderer/media_recorder/media_recorder_handler.cc
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/content/renderer/media_recorder/media_recorder_handler.h
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness-expected.txt
[add] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.h
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl
[add] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/Source/modules/media_capabilities/MediaEncodingConfiguration.idl
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/f7352cd198a784420184136e78cc14f85ff69c3a/third_party/WebKit/public/platform/WebMediaRecorderHandler.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dfce7635bf351e5ead9e6607bd068de121b1f92

commit 8dfce7635bf351e5ead9e6607bd068de121b1f92
Author: mcasas <mcasas@chromium.org>
Date: Tue May 02 04:33:19 2017

Media Capabilities encoding: wire the hardware encoding support

This CL wires the EncodingInfo() response param |smooth| to the
result of a new method in VideoTrackRecorder, namely
IsEncodingLikelyAccelerated() that simply surfaces the previously
somewhat internal information.  A couple of extra lines come from
refactoring similar code in either of the classes.

Testing it with https://codepen.io/miguelao/full/bWNwej.

BUG= 709181 

Review-Url: https://codereview.chromium.org/2832273002
Cr-Commit-Position: refs/heads/master@{#468558}

[modify] https://crrev.com/8dfce7635bf351e5ead9e6607bd068de121b1f92/content/renderer/media_recorder/media_recorder_handler.cc
[modify] https://crrev.com/8dfce7635bf351e5ead9e6607bd068de121b1f92/content/renderer/media_recorder/video_track_recorder.cc
[modify] https://crrev.com/8dfce7635bf351e5ead9e6607bd068de121b1f92/content/renderer/media_recorder/video_track_recorder.h

Cc: jcliang@chromium.org wuchengli@chromium.org posciak@chromium.org

Comment 7 by mcasas@chromium.org, Jul 18 2017

Description: Show this description

Comment 8 by mcasas@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)
Summary: Add support for media capabilities API for MediaRecorder encoding (was: add support for media capabilities API for encoding)

Comment 9 by foolip@chromium.org, Feb 27 2018

This issue is linked in MediaEncodingConfiguration.idl and media_recorder_handler.cc but is marked as fixed. Is there a separate bug for the "transmission" MediaEncodingType specifically?
#9: there isn't such a bug to my knowledge, and this issue tracked the
"recording" part only -- the TODO in [1] is pointing here wrongly.

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/media_capabilities/MediaEncodingConfiguration.idl?sq=package:chromium&dr&l=9
Miguel, is "transmission" still a TODO though? Can you file a separate bug and update the TODO?
By popular clamour (#9, #11), filed a new bug: Issue 817382,
updating the TODO now...
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3268f6c8e5983a6cb7a59cc87098b81024abb02c

commit 3268f6c8e5983a6cb7a59cc87098b81024abb02c
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed Feb 28 18:32:24 2018

Update TODO Issue number

TBR=mlamouri@chromium.org

Bug:  709181 , 817382
Change-Id: Ic64c1c3a0971c24efe459515c720cc6248205195
Reviewed-on: https://chromium-review.googlesource.com/941363
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539897}
[modify] https://crrev.com/3268f6c8e5983a6cb7a59cc87098b81024abb02c/third_party/WebKit/Source/modules/media_capabilities/MediaEncodingConfiguration.idl

Blocking: 905153

Sign in to add a comment