New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709179 link

Starred by 12 users
Status: Fixed
Owner:
█ bradnelson@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
█ binji@chromium.org
█ nattestad@chromium.org
█ komoroske@chromium.org
█ bradnelson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Launch-M-Target: 60-Stable

Blocked on:
issue 711809
issue 714582
issue 738774
Blocking:
issue 716320


Participants' hotlists:
Wasm-M59


Sign in to add a comment

SharedArrayBuffer + Atomics

Project Member Reported by bradnelson@chromium.org, Apr 6 2017 
Change description:
Adds shared memory + atomics + futex to JavaScript.

Changes to API surface:
* Adds SharedArrayBuffer mirroring ArrayBuffer
* Adds Atomics containing atomics + futex operations on SharedArrayBuffers
* Allows structured clone of SharedArrayBuffers to Web Workers

Links:
Merged into ECMAscript spec:
https://tc39.github.io/ecma262/
(Sections referencing Atomics / SharedArrayBuffer)
Last separate draft:
https://tc39.github.io/ecmascript_sharedmem/shmem.html

Support in other browsers:
Internet Explorer: No
Edge: Implemented, not yet released.
Firefox: Implemented, not yet released, expected soon.
Safari: Launched.

Comment 1 by bradnelson@chromium.org, Apr 13 2017

Labels: -M-59 M-60 Launch-M-Target-60-Stable

Comment 2 by falken@chromium.org, Apr 17 2017

Blockedon: 711809

Comment 3 by annevank...@gmail.com, Apr 24 2017

Blockedon: 714582

Comment 4 by seththompson@chromium.org, Apr 26 2017

Cc: bradnelson@chromium.org
 Issue 678410  has been merged into this issue.

Comment 5 by rbyers@chromium.org, May 3 2017

Blocking: 716320
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44b2d0c16507db40fa6a2a1bb3e3b5f932183be1

commit 44b2d0c16507db40fa6a2a1bb3e3b5f932183be1
Author: Brad Nelson <bradnelson@chromium.org>
Date: Fri Jul 28 21:48:44 2017

Disable SABs chrome side when feature is off, so we can default on in v8.

BUG= 709179 
R=binji@chromium.org

Change-Id: I41cdf04f60a6673f442d2f2e7546a6d4aeb57f07
Reviewed-on: https://chromium-review.googlesource.com/590775
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490520}
[modify] https://crrev.com/44b2d0c16507db40fa6a2a1bb3e3b5f932183be1/content/renderer/render_process_impl.cc

Comment 7 by bradnelson@chromium.org, Jul 28 2017

Cc: -seththompson@chromium.org nattestad@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7662e0634c3a057fa5d746912ee5af76e285c274

commit 7662e0634c3a057fa5d746912ee5af76e285c274
Author: Brad Nelson <bradnelson@chromium.org>
Date: Fri Jul 28 22:40:25 2017

Enable SharedArrayBuffer by default in standalone v8.

BUG= chromium:709179 
R=binji@chromium.org,hablich@chromium.org

Change-Id: I2efb3becc1ca9fef84008c82cd882ef11e2aa3f2
Reviewed-on: https://chromium-review.googlesource.com/589768
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46986}
[modify] https://crrev.com/7662e0634c3a057fa5d746912ee5af76e285c274/src/flag-definitions.h

Comment 9 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge

Comment 10 by horo@chromium.org, Sep 29 2017

Blockedon: 738774
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81ffb00e5f18db69247362a1b5f9c586c34099dd

commit 81ffb00e5f18db69247362a1b5f9c586c34099dd
Author: Ben Smith <binji@chromium.org>
Date: Tue Oct 17 21:09:11 2017

Remove SharedArrayBuffer flag

Bug:  chromium:709179 
Change-Id: I5633885b8479beccb0d455ccf40b5817eb6fe8df
Reviewed-on: https://chromium-review.googlesource.com/719460
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509531}
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/chrome/browser/about_flags.cc
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/content/child/runtime_features.cc
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/content/public/common/content_features.cc
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/content/public/common/content_features.h
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/content/renderer/render_process_impl.cc
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/third_party/WebKit/LayoutTests/fast/workers/worker-atomics-wait.html
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/third_party/WebKit/LayoutTests/fast/workers/worker-sharedarraybuffer-transfer.html
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/README.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/identity-not-preserved-expected.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-transferring-expected.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history-expected.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-domain-success.sub-expected.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https-expected.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-similar-but-cross-origin-success.sub-expected.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-simple-success-expected.txt
[delete] https://crrev.com/209a3efe99298af593c30fa5cfdf2339a6ca2890/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/81ffb00e5f18db69247362a1b5f9c586c34099dd/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Comment 12 by bradnelson@chromium.org, Mar 13 2018

Status: Fixed (was: Assigned)
As this was the original launch issue, closing out this item and tracking the re-launch here:
https://bugs.chromium.org/p/chromium/issues/detail?id=821270#
►

Sign in to add a comment