Remove the time limit on notification to code-review |
|||||||||
Issue descriptionCurrently, we have a hard time limit as of 60 minutes to stop sending notification to code-reviews. The reason is to reduce noise for some failures: Findit could take hours while sheriffs usually take action within ~30 minutes. Now that we have code to query info on code-review whether a revert is created or not. So we could deal with long-running analysis in a better way: e.g., we could still post a notification: * if no revert was created after failure time * if revert was created by sheriff/etc but no new comment was added * ...
,
Apr 6 2017
,
Apr 6 2017
,
Apr 6 2017
https://goto.google.com/findit-notifications-doc
,
Apr 6 2017
,
Apr 6 2017
,
Apr 6 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/85d7546331b9a6ab158d8c6ac1467214a10e3571 commit 85d7546331b9a6ab158d8c6ac1467214a10e3571 Author: Roberto Carrillo <robertocn@google.com> Date: Fri Apr 07 22:19:03 2017 [Findit] Remove time limit to notify found culprit code review. Also, clean up and document ShouldSendNotification. R=stgao,chanli BUG= 709177 Change-Id: I1ce7f8b3d950022cdb52a98964c5515bde9afa61 Reviewed-on: https://chromium-review.googlesource.com/470686 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/85d7546331b9a6ab158d8c6ac1467214a10e3571/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py [modify] https://crrev.com/85d7546331b9a6ab158d8c6ac1467214a10e3571/appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py [modify] https://crrev.com/85d7546331b9a6ab158d8c6ac1467214a10e3571/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py
,
Apr 10 2017
,
Apr 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by st...@chromium.org
, Apr 6 2017