Show all permissions in MD per-site settings view. |
||||||||
Issue descriptionIn order to link to per-site MD settings from Page Info ( Issue 655876 ) and hide permissions with default ask values in the Page Info Bubble ( Issue 657267 ), per-site MD settings should show all user-facing permissions, regardless of their default/current setting. I'm marking this as blocking Issue 657267 , but Issue 657267 can also be resolved on its own with certain other solutions. dbeam@, could you triage?
,
Apr 6 2017
Removing from Android, adding to Linux. emilyschechter@, do we want to keep hiding permissions with default values in Android? (We could add them e.g. behind an expand button.)
,
Apr 6 2017
c#2 let's break that out from this conversation. You mean Site Settings, not PageInfo on Android, right?
,
Apr 6 2017
I believe patricialor may be planning to take this on unless I'm mistaken?
,
Apr 7 2017
> You mean Site Settings, not PageInfo on Android, right? Yes. If we don't want it, no need to break out a conversation, though. (We've historically kept something things simpler on mobile, on purpose.)
,
Apr 7 2017
All this blocking is making my head spin... For example, this bug is blocking issue 709169 (Collection of requirements before hiding default permissions from Page Info), which is blocking issue 657267 (Hide permissions with default ask values in the Page Info Bubble), which is blocking this bug. We have a cyclic dependency in our bugs :)
,
Apr 7 2017
,
May 3 2017
,
May 4 2017
,
May 4 2017
I'll get it right eventually.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6d2eeee539252388096d5ddaf5644c093ad6c13 commit f6d2eeee539252388096d5ddaf5644c093ad6c13 Author: patricialor <patricialor@chromium.org> Date: Fri Jun 02 01:28:46 2017 MD Settings: Show all content settings in Site Details. The "Site Details" page currently only shows content settings that are set to a non-default setting for the given origin. This patch will show all content settings in "Site Details", regardless of whether they are still set to the default setting or not. BUG= 656758 , 709171 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2912253003 Cr-Commit-Position: refs/heads/master@{#476514} [modify] https://crrev.com/f6d2eeee539252388096d5ddaf5644c093ad6c13/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/f6d2eeee539252388096d5ddaf5644c093ad6c13/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/f6d2eeee539252388096d5ddaf5644c093ad6c13/chrome/browser/resources/settings/site_settings/site_details_permission.js [modify] https://crrev.com/f6d2eeee539252388096d5ddaf5644c093ad6c13/chrome/test/data/webui/settings/site_details_permission_tests.js [modify] https://crrev.com/f6d2eeee539252388096d5ddaf5644c093ad6c13/chrome/test/data/webui/settings/site_details_tests.js
,
Jun 2 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by lgar...@chromium.org
, Apr 6 2017