UMA Media.DetectedContainer not properly detecting MP4 files |
||||||
Issue descriptionWhen DetermineContainer() is checking MP4 files, it checks that the top-level tags match a list of tags as specified in the spec. However, it appears that tags other than the list can be specified. Examples in media/test/data/: bear_rotate_90.mp4 contains tag 'wide' crbug657437.mp4 contains tag 'mvhd' Proposed solution is to relax the list of tags allowed.
,
Apr 11 2017
Looks like this cut unknown rate by 75% on canary (~20% -> 5%)! before: https://uma.googleplex.com/p/chrome/histograms/?endDate=20170407&dayCount=1&histograms=Media.DetectedContainer&fixupData=true&showMax=true&filters=simple_version%2Ceq%2C59.0.3065.0%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial after: https://uma.googleplex.com/p/chrome/histograms/?endDate=20170408&dayCount=1&histograms=Media.DetectedContainer&fixupData=true&showMax=true&filters=simple_version%2Ceq%2C59.0.3066.0%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial I think this is worth merging back to m58 so we get better metrics sooner.
,
Apr 11 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 12 2017
Approving for M58.
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d78d8e1158db3c9feef2131617ab011098cc1f1d commit d78d8e1158db3c9feef2131617ab011098cc1f1d Author: John Rummell <jrummell@chromium.org> Date: Wed Apr 12 18:23:11 2017 Merge "Better detection of MP4 files" Relax the restrictions on the list of top-level boxes so that MP4 files are more reliably detected. BUG= 709166 TEST=updated test passes Review-Url: https://codereview.chromium.org/2797133009 Cr-Commit-Position: refs/heads/master@{#462759} (cherry picked from commit 169982cfc8c9619b413f133606cc832845e5d069) Review-Url: https://codereview.chromium.org/2811363002 . Cr-Commit-Position: refs/branch-heads/3029@{#680} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/d78d8e1158db3c9feef2131617ab011098cc1f1d/media/base/container_names.cc [modify] https://crrev.com/d78d8e1158db3c9feef2131617ab011098cc1f1d/media/base/container_names_unittest.cc
,
Apr 12 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 7 2017