New issue
Advanced search Search tips

Issue 709163 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

UMA Media.DetectedContainer not properly detecting MP3 files

Project Member Reported by jrumm...@chromium.org, Apr 6 2017

Issue description

When DetermineContainer() is checking for MP3 files, it skips over the file header and checks that there are several audio frames in the file. However, it only checks the first 8K of the file, so if the file contains an image (or other large fields) in the header, no audio frames are found and the file is not detected as MP3.

This needs to be fixed to check the header for valid entries.

Header format can be found at http://id3.org/Home.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06147322f84cd6dc908c41224b8e0c93f1da8518

commit 06147322f84cd6dc908c41224b8e0c93f1da8518
Author: jrummell <jrummell@chromium.org>
Date: Wed Apr 12 01:58:12 2017

Simplify checking for MP3 format

Assume that anything that starts with "ID3" is a MP3 format and don't
bother validating the content looking for audio frames.

BUG= 709163 
TEST=added files to MP3 test case

Review-Url: https://codereview.chromium.org/2807463003
Cr-Commit-Position: refs/heads/master@{#463894}

[modify] https://crrev.com/06147322f84cd6dc908c41224b8e0c93f1da8518/media/base/container_names.cc
[modify] https://crrev.com/06147322f84cd6dc908c41224b8e0c93f1da8518/media/base/container_names_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment