New issue
Advanced search Search tips

Issue 709150 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Reverb.cpp crashes on Box2D demo.

Project Member Reported by hongchan@chromium.org, Apr 6 2017

Issue description

See the stack trace below:

[10914:38943:0406/100856.105471:FATAL:Reverb.cpp(274)] Check failed: false.
0   libbase.dylib                       0x0000000102cd64fe base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x0000000102cd659d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x0000000102cd49fc base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x0000000102d6f3a0 logging::LogMessage::~LogMessage() + 80
4   libbase.dylib                       0x0000000102d6cea5 logging::LogMessage::~LogMessage() + 21
5   libblink_platform.dylib             0x000000013074def3 blink::Reverb::process(blink::AudioBus const*, blink::AudioBus*, unsigned long) + 3203
6   libblink_modules.dylib              0x000000013cb84e02 blink::ConvolverHandler::process(unsigned long) + 514
7   libblink_modules.dylib              0x000000013cb15c46 blink::AudioHandler::processIfNecessary(unsigned long) + 630
8   libblink_modules.dylib              0x000000013cb32449 blink::AudioNodeOutput::pull(blink::AudioBus*, unsigned long) + 649
9   libblink_modules.dylib              0x000000013cb2d077 blink::AudioNodeInput::pull(blink::AudioBus*, unsigned long) + 327
10  libblink_modules.dylib              0x000000013cb163a5 blink::AudioHandler::pullInputs(unsigned long) + 373
11  libblink_modules.dylib              0x000000013cb15b2f blink::AudioHandler::processIfNecessary(unsigned long) + 351
12  libblink_modules.dylib              0x000000013cb32449 blink::AudioNodeOutput::pull(blink::AudioBus*, unsigned long) + 649
13  libblink_modules.dylib              0x000000013cb2cea9 blink::AudioNodeInput::sumAllConnections(blink::AudioBus*, unsigned long) + 681
14  libblink_modules.dylib              0x000000013cb2d0e7 blink::AudioNodeInput::pull(blink::AudioBus*, unsigned long) + 439
15  libblink_modules.dylib              0x000000013cb0be52 blink::AudioDestinationHandler::render(blink::AudioBus*, blink::AudioBus*, unsigned long, blink::AudioIOPosition const&) + 738
16  libblink_platform.dylib             0x0000000130721651 blink::AudioDestination::render(blink::WebVector<float*> const&, unsigned long, double, double, unsigned long) + 1585
17  libcontent.dylib                    0x0000000126108030 content::RendererWebAudioDeviceImpl::Render(base::TimeDelta, base::TimeTicks, int, media::AudioBus*) + 688
18  libmedia.dylib                      0x00000001099ef83b media::AudioOutputDevice::AudioThreadCallback::Process(unsigned int) + 1291
19  libmedia.dylib                      0x00000001099ae885 media::AudioDeviceThread::ThreadMain() + 1221
20  libbase.dylib                       0x0000000102f90541 base::(anonymous namespace)::ThreadFunc(void*) + 705
21  libsystem_pthread.dylib             0x00007fffd9561aab _pthread_body + 180
22  libsystem_pthread.dylib             0x00007fffd95619f7 _pthread_body + 0
23  libsystem_pthread.dylib             0x00007fffd95611fd thread_start + 13

Note:
 - The Box2D demo is using a 4-channel IR for convolver.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26d2eea286b0c0ecc81ef2cf52815942d788ce1b

commit 26d2eea286b0c0ecc81ef2cf52815942d788ce1b
Author: rtoy <rtoy@chromium.org>
Date: Fri Apr 07 16:29:25 2017

Setting convolver buffer needs to update number of output channels

When the buffer for a ConvolverNode is set, the number of outputs
needs to be reconfigured based on the number of channels in the
response buffer.

BUG= 709150 
TEST=Convolver/convolver-response-4-chan.html

Review-Url: https://codereview.chromium.org/2799993002
Cr-Commit-Position: refs/heads/master@{#462888}

[modify] https://crrev.com/26d2eea286b0c0ecc81ef2cf52815942d788ce1b/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html
[modify] https://crrev.com/26d2eea286b0c0ecc81ef2cf52815942d788ce1b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/26d2eea286b0c0ecc81ef2cf52815942d788ce1b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

Comment 2 by rtoy@chromium.org, Apr 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment