MD Settings: Restore focus after closing dialog, for CrOS |
||||||||
Issue descriptionThis is the equivalent of issue 668313 . List of dialogs that have not been addressed follows: people_page/users_add_user_dialog.html people_page/easy_unlock_turn_off_dialog.html device_page/display_overscan_dialog.html device_page/drive_cache_dialog.html android_apps_page/android_apps_page.html bluetooth_page/bluetooth_device_dialog.html internet_page/network_proxy.html internet_page/network_siminfo.html internet_page/tether_connection_dialog.html people_page/password_prompt_dialog.html people_page/setup_fingerprint_dialog.html people_page/setup_pin_dialog.html printing_page/cups_add_printer_dialog_util.html I have not checked whether all those dialogs suffer from the focus being lost. In theory only dialogs that are removed from the DOM after closing should have the problem (usually happens with "dom-if restamp"). Examples of fixes exist in the referred bug (basically call focus() on the right element from a dialog's 'close' event handler). I have a CL for the channel switcher dialog (CrOS only) at https://codereview.chromium.org/2803853002.
,
Apr 10 2017
,
Apr 10 2017
,
Apr 12 2017
,
Apr 13 2017
Update: In: https://codereview.chromium.org/2817803002/: done: android_apps_page/android_apps_page.html done: bluetooth_page/bluetooth_device_dialog.html done: device_page/display_overscan_dialog.html done: device_page/drive_cache_dialog.html done: internet_page/network_proxy.html done: internet_page/network_siminfo.html done: printing_page/cups_add_printer_dialog_util.html unused (in development): internet_page/tether_connection_dialog.html done elsewhere: people_page/easy_unlock_turn_off_dialog.html people_page/users_add_user_dialog.html TODO: people_page/password_prompt_dialog.html people_page/setup_fingerprint_dialog.html people_page/setup_pin_dialog.html
,
Apr 13 2017
+jdufault@, +sammiequon@ - Can you take a look at these dialogs and ensure that when they are closed an appropriate element is focused? (See above CL for examples): people_page/password_prompt_dialog.html people_page/setup_fingerprint_dialog.html people_page/setup_pin_dialog.html
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e00979d16dd569963846451ce467626b1e86a04 commit 2e00979d16dd569963846451ce467626b1e86a04 Author: stevenjb <stevenjb@chromium.org> Date: Thu Apr 13 04:11:50 2017 MD Settings: CrOS: Focus elements on dialog close BUG= 709148 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817803002 Cr-Commit-Position: refs/heads/master@{#464291} [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/device_page/display.js [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/device_page/storage.html [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/device_page/storage.js [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/internet_page/network_proxy.html [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/internet_page/network_proxy.js [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/internet_page/network_siminfo.html [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/internet_page/network_siminfo.js [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/printing_page/cups_printers.html [modify] https://crrev.com/2e00979d16dd569963846451ce467626b1e86a04/chrome/browser/resources/settings/printing_page/cups_printers.js
,
Apr 13 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/092d3492acf064752a5776b4fd07ac21d39d2a98 commit 092d3492acf064752a5776b4fd07ac21d39d2a98 Author: stevenjb <stevenjb@chromium.org> Date: Thu Apr 13 19:19:51 2017 MD Settings: Users: Focus dialog buttons on close BUG= 709148 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2814423002 Cr-Commit-Position: refs/heads/master@{#464497} [modify] https://crrev.com/092d3492acf064752a5776b4fd07ac21d39d2a98/chrome/browser/resources/settings/people_page/fingerprint_list.html [modify] https://crrev.com/092d3492acf064752a5776b4fd07ac21d39d2a98/chrome/browser/resources/settings/people_page/fingerprint_list.js [modify] https://crrev.com/092d3492acf064752a5776b4fd07ac21d39d2a98/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/092d3492acf064752a5776b4fd07ac21d39d2a98/chrome/browser/resources/settings/people_page/lock_screen.js
,
Apr 13 2017
,
May 9 2017
9534.0.0, 60.0.3092.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 7 2017