New issue
Advanced search Search tips

Issue 709147 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Extension updater should send OS architecture

Project Member Reported by mxnguyen@chromium.org, Apr 6 2017

Issue description

Chrome extension updater only sends the architecture of Chrome (which is the platform for extensions), not the architecture of the OS.

We'd like Chrome extension updater to send the OS arch information in the update requests, to make it similar to Chrome component updater, which sends both the arch of the OS and of Chrome.


 
Cc: waff...@chromium.org sorin@chromium.org mevissen@chromium.org
Labels: -Type-Bug Type-Feature
Status: Assigned (was: Untriaged)
Untriaged w/ owner -> Assigned.
Owner: mxnguyen@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9cbbaa8cc8424476ef87dcf182111a64a7015c2

commit d9cbbaa8cc8424476ef87dcf182111a64a7015c2
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Tue Jan 09 01:27:25 2018

Add os_arch to CRX update requests.

Currently, only the Chrome arch is sent. This change would allow
extension updater to send both the Chrome arch and the OS arch to
the update server.

Bug: 709147
Change-Id: I0d48d46f5f6491d45116178cc08f41d6496d99ee
Reviewed-on: https://chromium-review.googlesource.com/837723
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527852}
[modify] https://crrev.com/d9cbbaa8cc8424476ef87dcf182111a64a7015c2/chrome/browser/extensions/webstore_installer_unittest.cc
[modify] https://crrev.com/d9cbbaa8cc8424476ef87dcf182111a64a7015c2/chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc
[modify] https://crrev.com/d9cbbaa8cc8424476ef87dcf182111a64a7015c2/components/update_client/update_query_params.cc
[modify] https://crrev.com/d9cbbaa8cc8424476ef87dcf182111a64a7015c2/components/update_client/update_query_params_unittest.cc

Sign in to add a comment