MIDI icon differs between Material site settings and Page Info |
|||||
Issue descriptionpage-info.png shows a keyboard, while md-content-settings.png uses a music note. maxwalker@: Which one should we be using? dbeam, do you know where the MD settings assets are stored? If Issue 647551 (Page Info: permission icons should use vector sources) would fix this, we should bump its priority.
,
Apr 6 2017
,
Apr 13 2017
MD-settings should be using the page-info icons for MIDI and javascript
,
Apr 13 2017
The JavaScript and downloads icons also differ. The fix will include new icons for JS and MIDI. Alan wants to review the downloads icon further (separately). Here's a screen shot showing the new icons. Note that the icons are a bit fuzzy due to scaling, that's covered in a separate bug Issue 709193
,
Apr 13 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94182b78878d55cb968e15312c66abfe21e3caf4 commit 94182b78878d55cb968e15312c66abfe21e3caf4 Author: dschuyler <dschuyler@chromium.org> Date: Thu Apr 13 23:04:09 2017 [MD settings] MIDI and JavaScript icons closer to page info icons This CL changes the icons for content settings of MIDI and JavaScript so that they are closer to those used in the page info dropdown (from the omnibox). BUG= 709142 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817083002 Cr-Commit-Position: refs/heads/master@{#464593} [modify] https://crrev.com/94182b78878d55cb968e15312c66abfe21e3caf4/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/94182b78878d55cb968e15312c66abfe21e3caf4/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/94182b78878d55cb968e15312c66abfe21e3caf4/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
,
Apr 13 2017
,
May 9 2017
Verified on ChromeOS 9534.0.0, 60.0.3092.0. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dbeam@chromium.org
, Apr 6 2017Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)