New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709137 link

Starred by 4 users
Status: Fixed
Owner:
flackr@chromium.org
Closed: Dec 4
Cc:
pdr@chromium.org
weiliangc@chromium.org
loyso@chromium.org
ajuma@chromium.org
skobes@chromium.org
█ jaydasika@chromium.org
chrishtr@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug

Blocked on:
issue 702774
issue 702777
issue 702832
Blocking:
issue 702350
issue 674317



Sign in to add a comment

Remove animation system dependency on layers.

Project Member Reported by wkorman@chromium.org, Apr 6 2017 
The animation subsystem has several areas that still look up or reference data via layer id. We'd like to replace all of these with element id and property tree node refs/data.

A majority of the changes required are in cc, but completing this work will also for example allow us to remove setting layer id in cc property tree nodes, and compositor element id in cc layers, in Blink's PaintArtifactCompositor.

See also:

 http://crbug.com/702774#c5 
 http://crbug.com/707281#c12 
http://crrev.com/2800983002

There have been a number of other involved bugs and discussion to date, please feel free to de-dupe this against those or those here as applicable.

Comment 1 by wkorman@chromium.org, Apr 7 2017

Blocking: 702350

Comment 2 by wkorman@chromium.org, Apr 7 2017

Blockedon: 702774 702777

Comment 3 by wkorman@chromium.org, Apr 7 2017

Blockedon: 702832
I think this is also blocked on scrollbar opacity work per https://codereview.chromium.org/2762123004

Comment 4 by wkorman@chromium.org, Apr 18 2017

Cc: skobes@chromium.org ajuma@chromium.org wkorman@chromium.org
 Issue 683774  has been merged into this issue.

Comment 5 by wkorman@chromium.org, May 11 2017

Cc: jaydasika@chromium.org loyso@chromium.org
 Issue 674258  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320f81a93e96beb1b3c77d728be99fd994a552a6

commit 320f81a93e96beb1b3c77d728be99fd994a552a6
Author: wkorman <wkorman@chromium.org>
Date: Fri May 12 01:15:05 2017

Remove Layer{Impl}::HasOnlyTranslationTransforms.

Inline the one internal reference in LayerImpl.

BUG= 709137 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2882543002
Cr-Commit-Position: refs/heads/master@{#471161}

[modify] https://crrev.com/320f81a93e96beb1b3c77d728be99fd994a552a6/cc/layers/layer.cc
[modify] https://crrev.com/320f81a93e96beb1b3c77d728be99fd994a552a6/cc/layers/layer.h
[modify] https://crrev.com/320f81a93e96beb1b3c77d728be99fd994a552a6/cc/layers/layer_impl.cc
[modify] https://crrev.com/320f81a93e96beb1b3c77d728be99fd994a552a6/cc/layers/layer_impl.h
Project Member

Comment 7 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fceabf03ed354db18981910bdbfb5a9ee31e59f

commit 8fceabf03ed354db18981910bdbfb5a9ee31e59f
Author: wkorman <wkorman@chromium.org>
Date: Fri May 12 02:00:41 2017

Apply filter mutation to effect tree directly for SPv2.

BUG= 709137 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2874083002
Cr-Commit-Position: refs/heads/master@{#471180}

[modify] https://crrev.com/8fceabf03ed354db18981910bdbfb5a9ee31e59f/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/8fceabf03ed354db18981910bdbfb5a9ee31e59f/cc/trees/layer_tree_host_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53a44329b63a7772bbd141040ba3744ccb49d881

commit 53a44329b63a7772bbd141040ba3744ccb49d881
Author: wkorman <wkorman@chromium.org>
Date: Fri May 12 15:39:23 2017

Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 and should eventually be removed, prefer instead limiting
as seen in this patch.

BUG= 709137 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2875133003
Cr-Commit-Position: refs/heads/master@{#471310}

[modify] https://crrev.com/53a44329b63a7772bbd141040ba3744ccb49d881/cc/layers/layer.cc
[modify] https://crrev.com/53a44329b63a7772bbd141040ba3744ccb49d881/cc/layers/layer.h
[modify] https://crrev.com/53a44329b63a7772bbd141040ba3744ccb49d881/cc/layers/layer_impl.cc
[modify] https://crrev.com/53a44329b63a7772bbd141040ba3744ccb49d881/cc/layers/layer_impl.h
[modify] https://crrev.com/53a44329b63a7772bbd141040ba3744ccb49d881/cc/trees/layer_tree_host_common_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03635b38e709b9b8ef610cb955c376bbc8bcfde1

commit 03635b38e709b9b8ef610cb955c376bbc8bcfde1
Author: wkorman <wkorman@chromium.org>
Date: Fri May 12 21:49:37 2017

Set opacity and transform mutations directly on property tree for SPv2.

BUG= 709137 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2878743002
Cr-Commit-Position: refs/heads/master@{#471453}

[modify] https://crrev.com/03635b38e709b9b8ef610cb955c376bbc8bcfde1/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/03635b38e709b9b8ef610cb955c376bbc8bcfde1/cc/trees/layer_tree_host_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6fc2f20dd92dbf5ea9b73ae877708efd0f432d4

commit a6fc2f20dd92dbf5ea9b73ae877708efd0f432d4
Author: wkorman <wkorman@chromium.org>
Date: Wed May 17 03:28:05 2017

Document some transform node animation fields.

Also add links to cc/README.md for two recent talks on property trees
that provide helpful overview background on the current and future
state of things.

BUG= 709137 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2883713002
Cr-Commit-Position: refs/heads/master@{#472302}

[modify] https://crrev.com/a6fc2f20dd92dbf5ea9b73ae877708efd0f432d4/cc/README.md
[modify] https://crrev.com/a6fc2f20dd92dbf5ea9b73ae877708efd0f432d4/cc/trees/transform_node.h
Project Member

Comment 12 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e006aee237d27eb7dbefae03551121dbad59dcae

commit e006aee237d27eb7dbefae03551121dbad59dcae
Author: wkorman <wkorman@chromium.org>
Date: Thu May 18 06:18:56 2017

Manage registering composited elements in PaintArtifactCompositor.

Circumvent three references to element id via the Layer when
SPv2 is enabled. PaintArtifactCompositor instead directly
handles layer registration/unregistration with the layer tree
host, and setting the host to commit in presence of animations.

BUG= 709137 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2888483002
Cr-Commit-Position: refs/heads/master@{#472703}

[modify] https://crrev.com/e006aee237d27eb7dbefae03551121dbad59dcae/cc/layers/layer.cc
[modify] https://crrev.com/e006aee237d27eb7dbefae03551121dbad59dcae/cc/layers/layer_unittest.cc
[modify] https://crrev.com/e006aee237d27eb7dbefae03551121dbad59dcae/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/e006aee237d27eb7dbefae03551121dbad59dcae/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/e006aee237d27eb7dbefae03551121dbad59dcae/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/290bf5b64df386923fb35f9b964c768153b3dd37

commit 290bf5b64df386923fb35f9b964c768153b3dd37
Author: wkorman <wkorman@chromium.org>
Date: Fri May 19 03:41:31 2017

Bit-pack bools in scroll and effect nodes.

BUG= 709137 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2892853002
Cr-Commit-Position: refs/heads/master@{#473062}

[modify] https://crrev.com/290bf5b64df386923fb35f9b964c768153b3dd37/cc/trees/effect_node.h
[modify] https://crrev.com/290bf5b64df386923fb35f9b964c768153b3dd37/cc/trees/scroll_node.cc
[modify] https://crrev.com/290bf5b64df386923fb35f9b964c768153b3dd37/cc/trees/scroll_node.h

Comment 15 by wkorman@chromium.org, May 22 2017 

Hack patch naively exploring  http://crbug.com/674258#c1  at http://crrev.com/2892793005.
Project Member

Comment 16 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3808a61e679c88a041a6bca1abb392a452d151ef

commit 3808a61e679c88a041a6bca1abb392a452d151ef
Author: Walter Korman <wkorman@chromium.org>
Date: Tue May 23 21:31:41 2017

Remove transform animation checkerboard prevention logic

Logic was originally added to track when a layer with a transform
animation has no missing tiles in http://crrev.com/1461243003 for
 http://crbug.com/554924 .

Many changes have since been made to image, animation, and paint
related logic. In the absence of a real world test case that is still
failing in the manner originally noted in 554294, prefer removing this
special-case logic.

Removes one LayerByElementId call site in LayerTreeHostImpl.

This patch is a step toward removing animation system dependency on
layers. Animation subsystem logic should involve only element ids and
their property tree nodes.

See also discussion in http://crrev.com/2895793002.

Bug:  702777 ,  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I91c8f0afc1727a096a03901810455a52633e51a0
Reviewed-on: https://chromium-review.googlesource.com/512987
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474063}
[modify] https://crrev.com/3808a61e679c88a041a6bca1abb392a452d151ef/cc/layers/layer_impl.cc
[modify] https://crrev.com/3808a61e679c88a041a6bca1abb392a452d151ef/cc/layers/layer_impl.h
[modify] https://crrev.com/3808a61e679c88a041a6bca1abb392a452d151ef/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/3808a61e679c88a041a6bca1abb392a452d151ef/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/3808a61e679c88a041a6bca1abb392a452d151ef/cc/trees/layer_tree_impl.cc
Project Member

Comment 17 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb83ceebd189762e06fb281ef9b11cd98b51aa43

commit eb83ceebd189762e06fb281ef9b11cd98b51aa43
Author: Walter Korman <wkorman@chromium.org>
Date: Tue May 30 04:21:22 2017

Refactor ElementIsAnimatingChanged to improve code sharing.

Addresses TODO from http://crrev.com/2758343002. I've been working in
this area recently and it would be a nice simplification to have this
code in one place.

Considered draw_property_utils and PropertyTree per previous ajuma@
suggestions on aforementioned change. Most of the state and method
calls in the logic are acting on a property tree instance, so the
latter seems to make the most sense.

Existing unit tests that cover this logic:

LayerTreeHostAnimationTestSetPotentiallyAnimatingOnLacDestruction.RunMultiThread_DelegatingRenderer
LayerTreeHostCommonTest.OpacityAnimatingOnPendingTree
LayerTreeHostCommonTest.OpacityAnimationsTrackingTest
LayerTreeHostCommonTest.TransformAnimationsTrackingTest

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iee3ecb26ed0909123251395131b12bfdd1cf621f
Reviewed-on: https://chromium-review.googlesource.com/513410
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475421}
[modify] https://crrev.com/eb83ceebd189762e06fb281ef9b11cd98b51aa43/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/eb83ceebd189762e06fb281ef9b11cd98b51aa43/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/eb83ceebd189762e06fb281ef9b11cd98b51aa43/cc/trees/property_tree.cc
[modify] https://crrev.com/eb83ceebd189762e06fb281ef9b11cd98b51aa43/cc/trees/property_tree.h

Comment 18 by wkorman@chromium.org, May 30 2017

Blocking: 674317
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92cdde0e4ec33af9360f9fb03c757ab8be7bec96

commit 92cdde0e4ec33af9360f9fb03c757ab8be7bec96
Author: Walter Korman <wkorman@chromium.org>
Date: Thu Jun 01 01:49:03 2017

Don't look up layer by element id for DCHECK in SPv2 scrolling logic.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I22266784ee485421f9f3748631e30c3d306572d1
Reviewed-on: https://chromium-review.googlesource.com/518314
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476139}
[modify] https://crrev.com/92cdde0e4ec33af9360f9fb03c757ab8be7bec96/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/92cdde0e4ec33af9360f9fb03c757ab8be7bec96/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Comment 20 by suzyh@chromium.org, Jun 13 2017

Cc: -suzyh@chromium.org
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f8e2395893e878ef27ae38f02deaf5a13250733

commit 7f8e2395893e878ef27ae38f02deaf5a13250733
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sat Jun 17 01:19:29 2017

Remove owning_layer_id from transform nodes in cc.

Bug:  718564 ,  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I03720b7e354d4e3d6dba621a01d40a941513c961
Reviewed-on: https://chromium-review.googlesource.com/538977
Commit-Queue: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480259}
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/layers/layer_impl.cc
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/layers/layer_impl.h
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/layers/layer_utils.cc
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/property_tree.cc
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/transform_node.cc
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/cc/trees/transform_node.h
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
[modify] https://crrev.com/7f8e2395893e878ef27ae38f02deaf5a13250733/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65bf0ffd6d8f7870ca74c0a83db2a54871f05392

commit 65bf0ffd6d8f7870ca74c0a83db2a54871f05392
Author: Walter Korman <wkorman@chromium.org>
Date: Thu Jul 27 16:09:59 2017

Move LayerIdByElementId to inline in LayerByElementId.

There are no other callers and we'd like to avoid any new ones being
added. LayerByElementId is itself deprecated. This method used to be
called from one other scroll related callsite which has since been
removed.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide0d8c8b40ded24f229ff5374e4a913f90e8ea1c
Reviewed-on: https://chromium-review.googlesource.com/588076
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489952}
[modify] https://crrev.com/65bf0ffd6d8f7870ca74c0a83db2a54871f05392/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/65bf0ffd6d8f7870ca74c0a83db2a54871f05392/cc/trees/layer_tree_impl.h
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ae14195edf3d735316df7413e3a4efce1736a0d

commit 0ae14195edf3d735316df7413e3a4efce1736a0d
Author: Walter Korman <wkorman@chromium.org>
Date: Fri Jul 28 01:48:13 2017

Remove Layer::OnScrollOffsetAnimated as it's a no-op.

Removes a call to LayerByElementId.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I711d13171a591eb0faa55f8d3247facb940bd5c9
Reviewed-on: https://chromium-review.googlesource.com/590585
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490193}
[modify] https://crrev.com/0ae14195edf3d735316df7413e3a4efce1736a0d/cc/layers/layer.cc
[modify] https://crrev.com/0ae14195edf3d735316df7413e3a4efce1736a0d/cc/layers/layer.h
[modify] https://crrev.com/0ae14195edf3d735316df7413e3a4efce1736a0d/cc/trees/layer_tree_host.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f716057402f92e8c9cd1cf9ddca7249418f3f5c

commit 2f716057402f92e8c9cd1cf9ddca7249418f3f5c
Author: Walter Korman <wkorman@chromium.org>
Date: Fri Jul 28 04:58:48 2017

Update stale comments referencing deleted method.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5e1a1226a7274c237022bc897b26066232d5827e
Reviewed-on: https://chromium-review.googlesource.com/589647
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490270}
[modify] https://crrev.com/2f716057402f92e8c9cd1cf9ddca7249418f3f5c/cc/layers/layer.cc
[modify] https://crrev.com/2f716057402f92e8c9cd1cf9ddca7249418f3f5c/cc/layers/layer_impl.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1d2878f3e9c945e326f01ffde0472e8eb0e322e

commit f1d2878f3e9c945e326f01ffde0472e8eb0e322e
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Aug 02 18:18:05 2017

Add simple ToString support for some animation related classes.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5afe52f29511fbb9cd93b086602c48d28eb9f301
Reviewed-on: https://chromium-review.googlesource.com/592291
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491441}
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/cc/animation/animation.cc
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/cc/animation/animation.h
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/cc/animation/animation_player.cc
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/cc/animation/animation_player.h
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/cc/animation/animation_player_unittest.cc
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/cc/animation/animation_unittest.cc
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/ui/compositor/layer_animation_element.cc
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/ui/compositor/layer_animation_element.h
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/ui/compositor/layer_animation_element_unittest.cc
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/ui/compositor/layer_animation_sequence.cc
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/ui/compositor/layer_animation_sequence.h
[modify] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/ui/compositor/layer_animation_sequence_unittest.cc
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a12563568ae4ff50451bede95f9df0e648bddc4

commit 9a12563568ae4ff50451bede95f9df0e648bddc4
Author: Walter Korman <wkorman@chromium.org>
Date: Fri Aug 04 04:46:07 2017

Add ElementId::ToInternalValue and make ElementId::id_ private.

The number of references in cc and blink that reach directly into the
ElementId struct and reference id_ continues to grow. It seems now
worth making these explicit and potentially more easily maintainable
in future by adding a ToInternalValue method, documenting, and changing most
references (except the hash impl, which seems worth just making a
friend) to use the method instead.

Also use PRIu64 to print the raw type per:

https://stackoverflow.com/questions/9225567/how-to-print-a-int64-t-type-in-c

rather than static_cast antics.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ieafcd258b214363095c74fc5facd133878337b28
Reviewed-on: https://chromium-review.googlesource.com/601000
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491940}
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/cc/animation/animation_player.cc
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/cc/trees/element_id.cc
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/cc/trees/element_id.h
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/cc/trees/transform_node.cc
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/third_party/WebKit/Source/platform/graphics/CompositorElementId.h
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/third_party/WebKit/Source/platform/graphics/CompositorElementIdTest.cpp
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.cpp
[modify] https://crrev.com/9a12563568ae4ff50451bede95f9df0e648bddc4/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp
Project Member

Comment 27 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf674bfc704f094ef80eb240e7ee128078139436

commit cf674bfc704f094ef80eb240e7ee128078139436
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Aug 09 04:18:20 2017

Reference scroll tree for scroll animations in SPv2.

Also rename the incredibly verbose
ScrollAnimatorCompositorCoordinator::
  compositor_animation_attached_to_element_id_
member data to ScrollAnimatorCompositorCoordinator::
  element_id_.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib73bda9118d3614c83f312c1465e0d8e4a3e6edb
Reviewed-on: https://chromium-review.googlesource.com/604716
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492822}
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/frame/VisualViewport.h
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
[modify] https://crrev.com/cf674bfc704f094ef80eb240e7ee128078139436/third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h
Project Member

Comment 28 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a167bd8be975d40364d6cb142f9825122415d441

commit a167bd8be975d40364d6cb142f9825122415d441
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Aug 09 15:24:29 2017

Extract FakeScrollableArea from GraphicsLayerTest.

Intend to use to add unit tests for
ScrollAnimatorCompositorCoordinator in a separate patch. Currently
ScrollAnimatorCompositorCoordinator appears to have no direct unit
tests.

Bug:  709137 
Change-Id: I9f5201c3a1e7aa1a7ef88f9ee88fa4c7dc8ecadd
Reviewed-on: https://chromium-review.googlesource.com/607048
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492991}
[modify] https://crrev.com/a167bd8be975d40364d6cb142f9825122415d441/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/a167bd8be975d40364d6cb142f9825122415d441/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
[add] https://crrev.com/a167bd8be975d40364d6cb142f9825122415d441/third_party/WebKit/Source/platform/graphics/test/FakeScrollableArea.h
Project Member

Comment 29 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bf3489093c6e297e045f285df0e456d758333f8

commit 1bf3489093c6e297e045f285df0e456d758333f8
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Aug 09 19:15:34 2017

Don't register/unregister element id in Layer for SPv2.

A follow up to https://codereview.chromium.org/2888483002,
essentially.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic5a26ebd65a1db81cc2e8d02d127f68991f03a44
Reviewed-on: https://chromium-review.googlesource.com/608905
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493090}
[modify] https://crrev.com/1bf3489093c6e297e045f285df0e456d758333f8/cc/layers/layer.cc
[modify] https://crrev.com/1bf3489093c6e297e045f285df0e456d758333f8/cc/layers/layer_unittest.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7479a94ae3039498708b4a64843fb4fc868d5ce

commit f7479a94ae3039498708b4a64843fb4fc868d5ce
Author: Walter Korman <wkorman@chromium.org>
Date: Tue Aug 15 22:07:15 2017

Don't register and unregister element for layer under SPv2.

Do not call MutatorHost::RegisterElement or
MutatorHost::UnregisterElement when in SPV2 mode, as
PaintArtifactCompositor will handle this
registration/unregistration.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7e92e67d86f29c9e5f039c244941cdf13729e3ce
Reviewed-on: https://chromium-review.googlesource.com/614587
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494568}
[modify] https://crrev.com/f7479a94ae3039498708b4a64843fb4fc868d5ce/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/f7479a94ae3039498708b4a64843fb4fc868d5ce/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/f7479a94ae3039498708b4a64843fb4fc868d5ce/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/f7479a94ae3039498708b4a64843fb4fc868d5ce/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/f7479a94ae3039498708b4a64843fb4fc868d5ce/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/f7479a94ae3039498708b4a64843fb4fc868d5ce/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
[modify] https://crrev.com/f7479a94ae3039498708b4a64843fb4fc868d5ce/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Comment 31 by alancutter@chromium.org, Aug 16 2017

Cc: -alancutter@chromium.org
Project Member

Comment 32 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b42b1358172e5d33c8a788fd066dd370981f7a2

commit 1b42b1358172e5d33c8a788fd066dd370981f7a2
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Aug 16 20:48:48 2017

Simplify LayerTreeHost element registration.

Always use the passed in element id rather than pulling the element id
from the layer.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic4585533baaf9980ba51c99b872a8dde39b54bab
Reviewed-on: https://chromium-review.googlesource.com/616178
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494939}
[modify] https://crrev.com/1b42b1358172e5d33c8a788fd066dd370981f7a2/cc/layers/layer.cc
[modify] https://crrev.com/1b42b1358172e5d33c8a788fd066dd370981f7a2/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/1b42b1358172e5d33c8a788fd066dd370981f7a2/cc/trees/layer_tree_host.h
[modify] https://crrev.com/1b42b1358172e5d33c8a788fd066dd370981f7a2/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
Project Member

Comment 33 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faf77271530be1dd9013e72484ec900a4b1d0cef

commit faf77271530be1dd9013e72484ec900a4b1d0cef
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Aug 23 02:35:21 2017

Remove unused LayerTreeHostImpl::AnimationsPreserveAxisAlignment.

Removes a usage of LayerImpl::element_id(). Originally planned to
revise this to pass the element id rather than the layer, only to
find this to be, in fact, dead code.

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic50097ab522f560a1a2bdf916407ac7815ca109c
Reviewed-on: https://chromium-review.googlesource.com/627023
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496566}
[modify] https://crrev.com/faf77271530be1dd9013e72484ec900a4b1d0cef/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/faf77271530be1dd9013e72484ec900a4b1d0cef/cc/trees/layer_tree_host_impl.h
Project Member

Comment 34 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af60f63989a955ec528150cd934b81d002caf234

commit af60f63989a955ec528150cd934b81d002caf234
Author: Walter Korman <wkorman@chromium.org>
Date: Thu Aug 24 22:52:39 2017

Clean up LayerImpl element id animation references.

Inline the only non-test usage of
HasPotentiallyRunningTransformAnimation (and test one as well).

Remove unused HasAnimationThatInflatesBounds,
HasFilterAnimationThatInflatesBounds and
TransformAnimationBoundsForBox methods.

Remove unimplemented FilterAnimationBoundsForBox method
as it was added at least a year ago and TODO owner is no
longer working on animation logic.

Bug:  709137 ,  252472 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If4074a5cf0bb180f02d0b10c7017eca54beed719
Reviewed-on: https://chromium-review.googlesource.com/627622
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497233}
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/animation/animation_host.cc
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/animation/animation_host.h
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/animation/animation_player.cc
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/animation/animation_player.h
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/animation/element_animations.cc
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/animation/element_animations.h
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/layers/layer_impl.cc
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/layers/layer_impl.h
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/af60f63989a955ec528150cd934b81d002caf234/cc/trees/mutator_host.h
Project Member

Comment 35 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2653cfab2f72876064cb670f7421c13655bff34e

commit 2653cfab2f72876064cb670f7421c13655bff34e
Author: Walter Korman <wkorman@chromium.org>
Date: Wed Aug 30 23:55:33 2017

Lazily remove element ids from LayerTreeImpl animation maps.

Cease removing them at time of layer unregistration. Removes
three references to LayerImpl::element_id().

Bug:  709137 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib637c35087530fa58721c1a6c0241065669d7695
Reviewed-on: https://chromium-review.googlesource.com/627026
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498677}
[modify] https://crrev.com/2653cfab2f72876064cb670f7421c13655bff34e/cc/layers/layer_impl.cc
[modify] https://crrev.com/2653cfab2f72876064cb670f7421c13655bff34e/cc/trees/layer_tree_impl.cc
Project Member

Comment 36 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5acfb96b2ad28a2d414c31c6ce27085261392fe

commit b5acfb96b2ad28a2d414c31c6ce27085261392fe
Author: Peter Mayo <petermayo@chromium.org>
Date: Wed Sep 13 20:05:10 2017

Remove an indirection of ScrollOffset through LayerImpl

Refactor LayerTreeHostImpl::GetScrollOffsetForAnimation to not use
GetLayerByElementId.  The layer is going to go back to the property
tree anyway to get the scroll offset.  If the element id is not
there it too will fall back to gfx::ScrollOffset(), so we don't
need to use the implicit check on the element id before calling it.

R=wkorman@chromium.org, pdr@chromium.org
CC=​flackr@chromium.org
BUG= 709137 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4495814e925d10c3f6e359fd04a75f89b7ebd3d2
Reviewed-on: https://chromium-review.googlesource.com/656043
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501724}
[modify] https://crrev.com/b5acfb96b2ad28a2d414c31c6ce27085261392fe/cc/layers/layer_impl.cc
[modify] https://crrev.com/b5acfb96b2ad28a2d414c31c6ce27085261392fe/cc/layers/layer_impl.h
[modify] https://crrev.com/b5acfb96b2ad28a2d414c31c6ce27085261392fe/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/b5acfb96b2ad28a2d414c31c6ce27085261392fe/cc/trees/layer_tree_host_unittest_animation.cc
[modify] https://crrev.com/b5acfb96b2ad28a2d414c31c6ce27085261392fe/cc/trees/layer_tree_impl.h
Project Member

Comment 37 by bugdroid1@chromium.org, Sep 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e8f3adfdaca42403bf90dda5baabe70ca1fbc3a

commit 0e8f3adfdaca42403bf90dda5baabe70ca1fbc3a
Author: Peter Mayo <petermayo@chromium.org>
Date: Thu Sep 14 03:34:02 2017

Remove an indirection of ScrollOffset through Layer

Refactor LayerTreeHost::GetScrollOffsetForAnimation to not use
GetLayerByElementId.  The layer is going to go back to the property
tree anyway to get the scroll offset.  If the element id is not
there it too will fall back to gfx::ScrollOffset(), so we don't
need to use the implicit check on the element id before calling it.

As this is the last call to Layer::GetScrollOffsetForAnimation
it is also removed

R=wkorman@chromium.org, pdr@chromium.org
CC=​flackr@chromium.org
BUG= 709137 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5b9cda04924b7782c695c27d6c9fb07cb9b866da
Reviewed-on: https://chromium-review.googlesource.com/656049
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501860}
[modify] https://crrev.com/0e8f3adfdaca42403bf90dda5baabe70ca1fbc3a/cc/layers/layer.cc
[modify] https://crrev.com/0e8f3adfdaca42403bf90dda5baabe70ca1fbc3a/cc/layers/layer.h
[modify] https://crrev.com/0e8f3adfdaca42403bf90dda5baabe70ca1fbc3a/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/0e8f3adfdaca42403bf90dda5baabe70ca1fbc3a/cc/trees/layer_tree_host.h
[modify] https://crrev.com/0e8f3adfdaca42403bf90dda5baabe70ca1fbc3a/cc/trees/layer_tree_host_unittest_animation.cc

Comment 38 by wkorman@chromium.org, Dec 7 2017

Owner: flackr@chromium.org
Any remaining work here is owned by WAT folks, passing to them.

Comment 39 by petermayo@chromium.org, Feb 7 2018

Labels: Hotlist-CodeHealth

Comment 40 by flackr@chromium.org, Dec 4

Status: Fixed (was: Assigned)
I believe that animations no longer depend on layers and operate through the property tree nodes they affect.

As of landing https://chromium-review.googlesource.com/c/chromium/src/+/1347784 animations use the list of ElementIds present in the property tree.

In https://chromium-review.googlesource.com/c/chromium/src/+/1355326 I stopped registering non scrolling layers in the element id to layer map, and stopped even informing AnimationHost about layers.

Comment 41 by chrishtr@chromium.org, Dec 4 

\o/
►

Sign in to add a comment