New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709135 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until July 2018
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Evaluate and re-enable testHistoryEntriesStatusCell if necessary

Project Member Reported by liaoyuke@chromium.org, Apr 6 2017

Issue description

testHistoryEntriesStatusCell rely on wireless connection and these two tests fail reliably when running on devices with WIFI turned off.

Please evaluated if this test can be converted to not rely on wireless connection, if not, maybe considering moving this test to ExternalURLTestCase.
 
Hi Sergio,

I'm assigning this to you because you are the owner of ui/history.

Please re-assign if necessary.
Cc: cma...@chromium.org

Comment 3 by sczs@chromium.org, Apr 7 2017

Cc: sczs@chromium.org
Owner: ramyasharma@chromium.org
I'm re-assigning to ramyasharma@ since she will own History now. 

Since this is a Beta Blocker it will probably be good to get it done before late April, please let us know if you don't have the bandwidth or if you have any questions.


Comment 4 by sczs@chromium.org, Apr 7 2017

Sorry, probably around Mid-April, cmasso@ can confirm. 
In any case, the sooner we take a look the better :) 
We are branching M59 on April 13th. All RBB should be fixed by then so we can have an official M59 Beta
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac504ddefaadc3b933db8cffde4a599539c89b79

commit ac504ddefaadc3b933db8cffde4a599539c89b79
Author: ramyasharma <ramyasharma@chromium.org>
Date: Mon Apr 10 23:22:06 2017

Removes wifi dependency for testHistoryEntriesStatusCell, so that it
passes reliably when running on devices with WIFI turned off.

The test, was checking the web contents of the URL as the last step
which is unnecessary. This test is meant to test the history entries,
and that the right number of tabs are opened in the end. The
contents of the URL are not important.

BUG= 709135 

Review-Url: https://codereview.chromium.org/2806253002
Cr-Commit-Position: refs/heads/master@{#463441}

[modify] https://crrev.com/ac504ddefaadc3b933db8cffde4a599539c89b79/ios/chrome/browser/ui/history/history_ui_egtest.mm

Status: Fixed (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment