Hi Louis,

I assigned this to you because you are the owner of ios/chrome/browser/metrics.

Please re-assign if necessary.

Please evaluated if this test can be converted to not rely on external URL, if not, maybe considering moving this test to ExternalURLTestCase.

Louis any update? Please add your assessment

Eugene, maybe you will know.

The test is basically loading an invalid URL, but expects the error page to be about "This site can’t be reached", but since the network is down, the "There is no Internet connection" takes precedence.

I guess this is expected in the logic of the loading errors? Can it be faked/bypassed?
Otherwise, the solution is to move the test to externalURL, as it really depends on the network.

Thanks!

I think liaoyuke@ (cc'd) has encountered this, as part of Wi-Fi problems on our bots.

Actually, I filed this bug. https://bugs.chromium.org/p/chromium/issues/detail?id=694662 is discussing a solution to fake error page, and that's maybe what you are looking for.

Menglu is trying to understand if we can trigger WKWebView's error, w/o actually using network  crbug.com/694662 . 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb7020961d6e218330eef899e33aef7a865219ae

commit eb7020961d6e218330eef899e33aef7a865219ae
Author: lpromero <lpromero@chromium.org>
Date: Tue May 02 15:27:43 2017

Move testEvictedTabReloadFailure to an external URL egtest target.

BUG= 709126 
R=baxley@chromium.org

Review-Url: https://codereview.chromium.org/2836403002
Cr-Commit-Position: refs/heads/master@{#468640}

[modify] https://crrev.com/eb7020961d6e218330eef899e33aef7a865219ae/ios/chrome/browser/metrics/BUILD.gn
[add] https://crrev.com/eb7020961d6e218330eef899e33aef7a865219ae/ios/chrome/browser/metrics/external_url_tab_usage_recorder_egtest.mm
[modify] https://crrev.com/eb7020961d6e218330eef899e33aef7a865219ae/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[add] https://crrev.com/eb7020961d6e218330eef899e33aef7a865219ae/ios/chrome/browser/metrics/tab_usage_recorder_test_util.h
[add] https://crrev.com/eb7020961d6e218330eef899e33aef7a865219ae/ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm
[modify] https://crrev.com/eb7020961d6e218330eef899e33aef7a865219ae/ios/chrome/test/earl_grey/BUILD.gn

[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.

Removing "Blocked on"  issue 694662 . It's related but not blocking anymore.

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d23f39e6be07bcb69c006fa6727fb64ffea3f17

commit 0d23f39e6be07bcb69c006fa6727fb64ffea3f17
Author: Louis Romero <lpromero@google.com>
Date: Tue May 02 16:05:06 2017

Move testEvictedTabReloadFailure to an external URL egtest target.

BUG= 709126 
R=baxley@chromium.org

Review-Url: https://codereview.chromium.org/2836403002
Cr-Commit-Position: refs/heads/master@{#468640}
(cherry picked from commit eb7020961d6e218330eef899e33aef7a865219ae)

Review-Url: https://codereview.chromium.org/2856933002 .
Cr-Commit-Position: refs/branch-heads/3071@{#352}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/0d23f39e6be07bcb69c006fa6727fb64ffea3f17/ios/chrome/browser/metrics/BUILD.gn
[add] https://crrev.com/0d23f39e6be07bcb69c006fa6727fb64ffea3f17/ios/chrome/browser/metrics/external_url_tab_usage_recorder_egtest.mm
[modify] https://crrev.com/0d23f39e6be07bcb69c006fa6727fb64ffea3f17/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[add] https://crrev.com/0d23f39e6be07bcb69c006fa6727fb64ffea3f17/ios/chrome/browser/metrics/tab_usage_recorder_test_util.h
[add] https://crrev.com/0d23f39e6be07bcb69c006fa6727fb64ffea3f17/ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm
[modify] https://crrev.com/0d23f39e6be07bcb69c006fa6727fb64ffea3f17/ios/chrome/test/earl_grey/BUILD.gn

Louis,
are there any test steps to verify this issue manually, thanks.

$ python ios_internal/tools/tests/failed_tests_history.py -t ExternalURLTabUsageRecorderTestCase.testEvictedTabReloadFailure -l 22

returns nothing. I tried with higher values of |limit| and HTTP_REQUEST_TIME_OUT_SECONDS, but it fails like this:

$ python ios_internal/tools/tests/failed_tests_history.py -t ExternalURLTabUsageRecorderTestCase.testEvictedTabReloadFailure -l 25
HTTP error at HTTP Error 500: Internal Server Error
Reduce |limit| or increase |HTTP_REQUEST_TIME_OUT_SECONDS|

We haven't seen this test fail again, so I'd consider it verified on trunk. I am not sure how to check easily on the branch apart looking at the logs on the branch since the cherry-pick.