New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 709125 link

Starred by 3 users
Status: Fixed
Owner:
briannorris@chromium.org
Closed: Apr 2018
Cc:
briannorris@chromium.org
█ cernekee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

mwifiex: Don't store mac address randomization as a driver-wide state

Project Member Reported by kirtika@chromium.org, Apr 6 2017 
A recent test failure[1] root-caused to mac address randomization [2]
led us to look at disabling mac address randomization for the test. 
MAC address randomization is a per-command thing, specified by a flag 
in the scan commands issued to the driver. The only entity keeping 
state about whether mac address randomization is enabled or not should
be shill. One of our drivers keeps no state about whether mac addr randomization is enabled or not. Marvell stores this field (stateful)
in mwifiex_private. Consider fixing this upstream. 


[1] https://chromium-review.googlesource.com/#/c/469072/
[2] https://b.corp.google.com/issues/35573298

Comment 1 by briannorris@chromium.org, Apr 6 2017

Components: OS>Systems>Network
Perfectly fine to file the bug, but unless you feel like handling this yourself, you might want to bug Marvell about it. And sometimes they handle the partner issue tracker better.

Also, I think this form of state (once fixed per [1]) is not so hard to reason about, really. We're clobbering the state to match the presence of NL80211_SCAN_FLAG_RANDOM_ADDR every time we get a scan command, AFAICT, which does effectively the same thing.

Comment 2 by kirtika@chromium.org, Apr 6 2017 

Will move it to partner tracker.
You've fixed the scan command handling with the clobbering, my main concern is that piece of state being used (since its available) for future code i.e. (making up an example here) - probe response handling.

Comment 3 by kirtika@chromium.org, Apr 6 2017

Status: Unconfirmed (was: Untriaged)
b/37088079
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 9 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by briannorris@chromium.org, Apr 11 2018

Owner: briannorris@chromium.org
Status: Fixed (was: Archived)
Companion bug was fixed.
►

Sign in to add a comment