New issue
Advanced search Search tips

Issue 709118 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Android: enable HW encoding

Project Member Reported by braveyao@chromium.org, Apr 6 2017

Issue description

Android video encode accelerator was disabled based on gpu blacklist since the day it's born, as in https://codereview.chromium.org/74563002/#ps330001.

We have tweaked the encoding codes on Android a bit. Now H264 has been enabled by default for WebRTC calls. And VP8 is enabled for MediaRecorder too recently. Both are done by bypassing the blacklist.

So it's timing to remove the entry in gpu blacklist.

PS: VP8 will still keep disabling for WebRTC for now, behind a flag though.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96c9b34ea924ed4300f90839cab36adf4f8eaecc

commit 96c9b34ea924ed4300f90839cab36adf4f8eaecc
Author: braveyao <braveyao@chromium.org>
Date: Tue Apr 25 18:23:19 2017

Android: enable HW encoding

Android video encode accelerator was disabled based on gpu blacklist since
the day it's born, as in https://codereview.chromium.org/74563002/#ps330001.
We have tweaked the encoding codes on Android a bit. Now H264 has been
enabled by default for WebRTC calls. And VP8&H264 are enabled for MediaRecorder
too recently. Both are done by bypassing the blacklist.
So it's time to enable HW encoding on Android.

This CL is to revert the PS#3 of https://codereview.chromium.org/74563002,
as removing the entry in gpu blacklist to enable HW encoing on Android.
And add a flag to keep VP8 disabled for WebRTC for now.

BUG= 709118 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2839823002
Cr-Commit-Position: refs/heads/master@{#467050}

[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/chrome/browser/about_flags.cc
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/content/public/browser/gpu_utils.cc
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/content/public/common/content_features.cc
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/content/public/common/content_features.h
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/content/public/common/content_switches.cc
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/content/public/common/content_switches.h
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/content/renderer/media/gpu/rtc_video_encoder_factory.cc
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/gpu/config/software_rendering_list.json
[modify] https://crrev.com/96c9b34ea924ed4300f90839cab36adf4f8eaecc/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment