New issue
Advanced search Search tips

Issue 709116 link

Starred by 1 user
Status: Fixed
Owner:
patricia...@chromium.org
Closed: Apr 2017
Cc:
benwells@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Protocol handler permission prompt is missing right padding in Cocoa

Project Member Reported by lgar...@chromium.org, Apr 6 2017 
Chrome 59.0.3053.3
OSX 10.12.3

What steps will reproduce the problem?
(1) Visit http://permission.site, click on "Protocol Handler", and grant.
(2) Visit https://permission.site (HTTPS) and click on "Protocol Handler"

What is the expected result?
Equal padding on both sides.

What happens instead?
The right side does not have enough padding.
Screen Shot 2017-04-06 at 10.53.14.png
53.5 KB View Download
Screen Shot 2017-04-06 at 10.52.32.png
66.5 KB View Download
Screen Shot 2017-04-06 at 10.57.50.png
55.7 KB View Download

Comment 1 by a...@chromium.org, Apr 6 2017

Owner: benwells@chromium.org
Status: Assigned (was: Untriaged)
This a permission request bubble.

Ben, can you decide what to do here?

Comment 2 by lgar...@chromium.org, Apr 6 2017

Summary: Protocol handler permission prompt is missing right padding in Cocoa (was: Protocol handler permission prompt is missing right padding in Cocoa when there is an existing handler)
The existing handler is probably not the issue. I bet this happens with any long string, which may happen in other locales.

Comment 3 by benwells@chromium.org, Apr 7 2017

Labels: M-60

Comment 4 by benwells@chromium.org, Apr 7 2017

Cc: patricia...@chromium.org
Should be simple to fix, I guess. Might take me a while as I don't have a Mac. Adding Patti who might be able to get to it before me...

Comment 5 by patricia...@chromium.org, Apr 20 2017

Cc: -patricia...@chromium.org benwells@chromium.org
Owner: patricia...@chromium.org
Status: Started (was: Assigned)
Started at https://codereview.chromium.org/2833463003/, benwells -> CC
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca8708632799fafe05e889d5a026249fa630dbab

commit ca8708632799fafe05e889d5a026249fa630dbab
Author: patricialor <patricialor@chromium.org>
Date: Fri Apr 21 00:34:59 2017

Permissions/Mac: Fix missing right padding for Cocoa permission prompt bubbles.

See https://drive.google.com/open?id=0BzEa5HU1aAqBRnJ3N2xTV2JTU2M for before /
after screenshots.

BUG= 709116 

Review-Url: https://codereview.chromium.org/2833463003
Cr-Commit-Position: refs/heads/master@{#466199}

[modify] https://crrev.com/ca8708632799fafe05e889d5a026249fa630dbab/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm

Comment 7 by patricia...@chromium.org, Apr 21 2017

Status: Fixed (was: Started)

Comment 8 by lgar...@chromium.org, Apr 21 2017

Labels: Needs-TestConfirmation
Thanks! Attaching a screenshot for the public record.

TEST=The following steps:
(1) Visit http://permission.site, click on "Protocol Handler", and allow.
(2) Visit https://permission.site (HTTPS) and click on "Protocol Handler"
(3) Verify that the prompt in step (2) has padding to the right of the long line of text.
crrev.com%2F2833463003 PermissionBubbleController.png
24.1 KB View Download
►

Sign in to add a comment