New issue
Advanced search Search tips

Issue 709115 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

"TtsApiTest.EngineError" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 6 2017

Issue description

"TtsApiTest.EngineError" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIQsSBUZsYWtlIhZUdHNBcGlUZXN0LkVuZ2luZUVycm9yDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
When the test fails/flakes, ExtensionTtsEngineSendTtsEventFunction::Run fails to validate input arguments.  Unfortunately, I cannot tell which of the four EXTENSION_FUNCTION_VALIDATE can be blamed here.

[ RUN      ] TtsApiTest.EngineError
Xlib:  extension "RANDR" missing on display ":99".
[15857:15857:0405/125756.091105:WARNING:audio_manager.cc(295)] Multiple instances of AudioManager detected
[15857:15857:0405/125756.098985:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected
[15857:15857:0405/125756.149432:WARNING:password_store_factory.cc(249)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[15857:15857:0405/125756.564003:ERROR:bad_message.cc(22)] Terminating extension renderer for bad IPC message, reason 8
[15857:15857:0405/125756.564053:ERROR:bad_message.cc(22)] Terminating extension renderer for bad IPC message, reason 8
[15857:15857:0405/125756.564072:FATAL:extension_function.cc(150)] Check failed: false. ttsEngine.sendTtsEvent: bad message
#0 0x000002eb3d77 base::debug::StackTrace::StackTrace()
#1 0x000002ecc98b logging::LogMessage::~LogMessage()
#2 0x000002069f1e ExtensionFunction::BadMessage()
#3 0x00000206a18c ExtensionFunction::ValidationFailure()
#4 0x0000031284c6 ExtensionTtsEngineSendTtsEventFunction::Run()
#5 0x00000206a231 ExtensionFunction::RunWithValidation()
#6 0x00000206cbdf extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal()
#7 0x00000206c554 extensions::ExtensionFunctionDispatcher::Dispatch()
#8 0x00000208cf8f _ZN3IPC8MessageTI29ExtensionHostMsg_Request_MetaSt5tupleIJ31ExtensionHostMsg_Request_ParamsEEvE8DispatchIN10extensions28ExtensionWebContentsObserverES8_N7content15RenderFrameHostEMS8_FvPSA_RKS3_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#9 0x00000208ce7e extensions::ExtensionWebContentsObserver::OnMessageReceived()
FWIW, the flakiness doesn't seem to be OS-specific - I see flakes happening on Linux / linux_chromium_rel_ng, ChromeOS / linux_chromium_chromeos_rel_ng, Mac / mac_chromium_rel_ng
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
rdevlin.cronin@, could you please (since this seems related to extension APIs) help triaging and routing this to the appropriate dev?

I'll go ahead and put together a CL to disable this test (which makes me sad, but without better understanding of the failure I don't see a good alternative approach).
Hmmm... if I just disable the test |#if defined(OS_POSIX)|, then it will keep running on Windows making me much less sad.  Let's try this approach first and hope there will be no flakes on Windows.
Components: Platform>Extensions>API
Labels: OS-Chrome OS-Linux OS-Mac
Cc: dmazz...@chromium.org dtseng@chromium.org
Hmmm... maybe this belongs to TTS aka chrome/browser/speech/OWNERS - adding them to CC.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/991302e9a650020672202c472a3998a4afdfede2

commit 991302e9a650020672202c472a3998a4afdfede2
Author: lukasza <lukasza@chromium.org>
Date: Thu Apr 06 21:10:06 2017

Disable TtsApiTest.EngineError browser test on most OS-es (due to flakiness).

BUG=709115
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2805533004
Cr-Commit-Position: refs/heads/master@{#462619}

[modify] https://crrev.com/991302e9a650020672202c472a3998a4afdfede2/chrome/browser/speech/extension_api/tts_extension_apitest.cc

Labels: -Pri-1 -Sheriff-Chromium Pri-2
After #c7 this bug hopefully won't need attention from Chromium tree sheriffs.
Components: Blink>Speech
Owner: dmazz...@chromium.org
-> dmazzoni@ for tts

Sign in to add a comment