[Advanced Sync Settings] Move sWAA link to advanced sync settings |
||||||
Issue descriptionPer offline discussion, we should move the "Personalize Google Services" link to the advanced sync settings page. My recommendation: move it directly above the "Manage synced data" link (https://screenshot.googleplex.com/edozTkiEfc2). Alan - initially assigning to you for UX confirmation that that's the correct place to move the link. And please let us know if there are any other UX changes you'd like to make to the UI for the "Personalize Google Services" row, now that it's being moved into advanced sync settings. Then re-assign to Tommy for implementation.
,
Apr 7 2017
01-main - remove "Personalize Google services" - remove the secondary text under "Manage Supervised Users" / make a single-line row 02-subpage* - add "Personalize Google services" above "Manage synced data" - remove google "G" from row *disregard checkboxes in the mock. Switches are WAI.
,
Apr 7 2017
,
Apr 7 2017
,
Apr 7 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7df3fa56f309bdf62e77a147b89ba848c10c165f commit 7df3fa56f309bdf62e77a147b89ba848c10c165f Author: tommycli <tommycli@chromium.org> Date: Fri Apr 07 23:25:48 2017 MD Settings: Remove secondary text under Manage Supervised Users. BUG= 709111 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2806023002 Cr-Commit-Position: refs/heads/master@{#463046} [modify] https://crrev.com/7df3fa56f309bdf62e77a147b89ba848c10c165f/chrome/app/settings_strings.grdp [modify] https://crrev.com/7df3fa56f309bdf62e77a147b89ba848c10c165f/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/7df3fa56f309bdf62e77a147b89ba848c10c165f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Apr 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41b9cfb8710fbeec6ead343de517cdb6fbd5d205 commit 41b9cfb8710fbeec6ead343de517cdb6fbd5d205 Author: tommycli <tommycli@chromium.org> Date: Sat Apr 08 00:00:40 2017 MD Settings: Move Activity Controls link to Sync subpage Moves the Activity Controls link, (a.k.a. the sWAA link) from the top-level People section to the Advanced Sync Settings subpage. BUG= 709111 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2805003005 Cr-Commit-Position: refs/heads/master@{#463061} [modify] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/chrome/app/settings_strings.grdp [modify] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/chrome/browser/resources/settings/people_page/people_page.js [modify] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/chrome/browser/resources/settings/people_page/sync_page.html [modify] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/chrome/browser/resources/settings/people_page/sync_page.js [modify] https://crrev.com/41b9cfb8710fbeec6ead343de517cdb6fbd5d205/chrome/test/data/webui/settings/people_page_test.js
,
Apr 8 2017
just checked this on HEAD, looks great also reduces flicker while we load md-settings, \o/
,
Apr 10 2017
Great, thanks!
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/474250dafbf9967b9ea41d4c423216ca0e54567d commit 474250dafbf9967b9ea41d4c423216ca0e54567d Author: tommycli <tommycli@chromium.org> Date: Wed Apr 12 22:35:33 2017 MD Settings: Remove leftover aria-describedby in Supervised Users link BUG= 709111 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813273002 Cr-Commit-Position: refs/heads/master@{#464179} [modify] https://crrev.com/474250dafbf9967b9ea41d4c423216ca0e54567d/chrome/browser/resources/settings/people_page/people_page.html |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bettes@chromium.org
, Apr 7 2017