New issue
Advanced search Search tips

Issue 709104 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature

Blocking:
issue 518942



Sign in to add a comment

bluetooth: macOS: remove all ns_object.get().property

Project Member Reported by jlebel@chromium.org, Apr 6 2017

Issue description

Status: Available (was: Untriaged)
Blocking: 518942
Components: -Blink>Bluetooth IO>Bluetooth
Labels: -Type-Bug Type-Feature

Comment 3 by jlebel@chromium.org, May 26 2017

Status: Fixed (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35be3092e0e4591024a4d3fa47b00160d3da1f79

commit 35be3092e0e4591024a4d3fa47b00160d3da1f79
Author: jlebel <jlebel@chromium.org>
Date: Fri May 26 19:55:28 2017

bluetooth: macOS: Removing useless |.get()|

Changing `object.get().value` to `[object value]`. ObjC dot notation for NSObjects
in Chrome should not be used (only for structs like NSSize).
And removing some other useless .get().

BUG= 709104 

Review-Url: https://codereview.chromium.org/2906883004
Cr-Commit-Position: refs/heads/master@{#475092}

[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/bluetooth_adapter_mac_unittest.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/bluetooth_low_energy_device_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/bluetooth_remote_gatt_service_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/test/bluetooth_test_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/test/mock_bluetooth_cbdescriptor_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/test/mock_bluetooth_cbservice_mac.mm
[modify] https://crrev.com/35be3092e0e4591024a4d3fa47b00160d3da1f79/device/bluetooth/test/mock_bluetooth_central_manager_mac.mm

Sign in to add a comment