New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709101 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 591803



Sign in to add a comment

The text of answers in suggest should be a consistent color.

Project Member Reported by jdonnelly@chromium.org, Apr 6 2017

Issue description

Per direction from UX, we want the text of answers to be a consistent color, as opposed to the mix of black and gray currently used. All text other than the suggestion text itself (e.g. "weather los angeles") and positive(green)/negative(red) text should be the "dimmed" text color (currently #646464) used for page titles and some answer text (e.g. the day of the week in weather answers).
 
Blocking: 591803
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93dc65041b3f7e4fe97ffc91b8ab3954a7a6bf6a

commit 93dc65041b3f7e4fe97ffc91b8ab3954a7a6bf6a
Author: jdonnelly <jdonnelly@chromium.org>
Date: Thu Apr 06 22:27:08 2017

Make the answers text color more consistent.

All answer text (other than the suggestion text and positive/negative
text) is now dimmed.

BUG= 709101 

Review-Url: https://codereview.chromium.org/2798223004
Cr-Commit-Position: refs/heads/master@{#462651}

[modify] https://crrev.com/93dc65041b3f7e4fe97ffc91b8ab3954a7a6bf6a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/289c30612a1d9dadd0bcbd6b6867d23de07bd871

commit 289c30612a1d9dadd0bcbd6b6867d23de07bd871
Author: jdonnelly <jdonnelly@chromium.org>
Date: Fri Apr 07 14:41:17 2017

Make the answers text color more consistent.

All answer text (other than the suggestion text and positive/negative
text) is now the de-emphasizing gray.

BUG= 709101 

Review-Url: https://codereview.chromium.org/2804143002
Cr-Commit-Position: refs/heads/master@{#462857}

[modify] https://crrev.com/289c30612a1d9dadd0bcbd6b6867d23de07bd871/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AnswerTextBuilder.java

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ab7c6059c16600fd7e1ffbb727e4aa2726d854e

commit 1ab7c6059c16600fd7e1ffbb727e4aa2726d854e
Author: jdonnelly <jdonnelly@chromium.org>
Date: Mon Apr 10 03:16:28 2017

Make the answers text color more consistent.

All answer text (other than the suggestion text and positive/negative
text) is now the de-emphasizing gray.

BUG= 709101 

Review-Url: https://codereview.chromium.org/2800853007
Cr-Commit-Position: refs/heads/master@{#463170}

[modify] https://crrev.com/1ab7c6059c16600fd7e1ffbb727e4aa2726d854e/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89669caf0861ddd3a08e3c474989de65cf6caff9

commit 89669caf0861ddd3a08e3c474989de65cf6caff9
Author: jdonnelly <jdonnelly@chromium.org>
Date: Mon Apr 10 15:42:58 2017

Make the answers text color more consistent.

All answer text (other than the suggestion text and positive/negative
text) is now the de-emphasizing gray.

BUG= 709101 

Review-Url: https://codereview.chromium.org/2805873002
Cr-Commit-Position: refs/heads/master@{#463275}

[modify] https://crrev.com/89669caf0861ddd3a08e3c474989de65cf6caff9/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm

Status: Fixed (was: Started)

Comment 7 by hdodda@chromium.org, Apr 18 2017

Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested the issue on Mac os 10.12.3 using chrome dev M59 #59.0.3071.9 and followed below steps :

1. Launched chrome and navigated to new tab page 
2. Typed "weather los angeles" and observed the text of the suggestions list displayed.

Attached screencast for reference.

@jdonnelly-- Could you please check attached screencast and confirm us if this is working as per the latest fix or if we had missed any steps in verifying the issue , please provide us the manual steps to verify the issue .

Thanks!
709101.mp4
561 KB View Download
Thanks for verifying.

Yes, the behavior from your screencast is correct. The bug description may be misleading. The answer text (e.g. "16oC Thu") is what appears below the suggestion text (e.g. "weather los angeles", "weather los angeles today"). The issue was that for some types of answers the answer text was black but for other types it was grey. All answer types should now have grey answer text. But all suggestion text was and still should be black.

Sign in to add a comment