Bluetooth: macOS: GetBluetoothRemote*Mac() should return |
||||
Issue descriptionhttps://codereview.chromium.org/2767813002/patch/190001/200002 "If so then maybe we should return a reference so that users of the function don't have to check if the descriptor is there. I recognize that we do this for all GetBluetoothRemote*Mac() functions already so maybe we should just fix it for all in a separate patch. Not high priority though."
,
May 27 2017
Those methods are used internally to test if the service/characteristics/descriptors exist. If not they are created during discovery phase. So far, I think only BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattDescriptor() could return a reference. But I feel the return value should not be changed, to be coherent with other APIs. Talking about coherence, this method should be renamed to BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattDescriptorMac(): crbug.com/727020 Giovanni, is it ok with you?
,
May 28 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ortuno@chromium.org
, Apr 6 2017Components: -Blink>Bluetooth IO>Bluetooth
Labels: -Type-Bug OS-Mac Type-Feature