New issue
Advanced search Search tips

Issue 709093 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mash: Crash reporter should treat chrome --mus as a "mash" crash

Project Member Reported by jamescook@chromium.org, Apr 6 2017

Issue description

For the initial mushrome release we're just going to turn on mus-ws and mus-gpu. Those processes get --mus instead of --mash. Tweak the system-level crash reporter to treat all these processes as "mash" crashes.

I think it's OK to treat all these as the same "product" in the crash dashboard. If we need a separate product for --mus it's easy to add later.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4cf1aea253f2cf34e5fceae89ea00dd59520542d

commit 4cf1aea253f2cf34e5fceae89ea00dd59520542d
Author: James Cook <jamescook@chromium.org>
Date: Mon Apr 17 21:06:21 2017

crash: Treat chrome --mus crashes as mash crashes

The initial release of mustash will use --mus for its processes.
A later release will add --mash for the system UI process. Treat
both chrome --mus and chrome --mus as "mash" crashes.

BUG= chromium:709093 
TEST=added unit test

Change-Id: If6a95c87e847c93042f5d2ffd63def06de7b1795
Reviewed-on: https://chromium-review.googlesource.com/470366
Commit-Ready: James Cook <jamescook@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4cf1aea253f2cf34e5fceae89ea00dd59520542d/crash-reporter/user_collector_test.cc
[modify] https://crrev.com/4cf1aea253f2cf34e5fceae89ea00dd59520542d/crash-reporter/user_collector.cc

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment