"blink_heap_unittests (with patch)" is flaky |
|||
Issue description"blink_heap_unittests (with patch)" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFibGlua19oZWFwX3VuaXR0ZXN0cyAod2l0aCBwYXRjaCkM. The chromium-try-flakes app is able to file bugs for individual tests when the test launcher is uploading results to the Test Results Server. If recent flakes above are caused by failing tests and you would like to have them filed as invidual bugs, please read more at https://goo.gl/eB0GLj. This flaky test/step was previously tracked in issue 628162 .
,
Apr 6 2017
,
Apr 6 2017
I am torn between disabling the tests just on OS_MACOS or reverting r462061 for now. I am leaning toward the latter, since the tests have been introduced relatively recently (just 1-2 days ago). OTOH, there were only 3 flakes over the last 3 days, so I'd rather get an ack from keishi@ first. keishi@ - WDYT?
,
Apr 7 2017
A possible fix is going through CQ: https://codereview.chromium.org/2804143004/ Removing Sheriff-Chromium label since no further action is needed if the fix works.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/324a183e05ececfc2079f06c65c3757354f13fd1 commit 324a183e05ececfc2079f06c65c3757354f13fd1 Author: keishi <keishi@chromium.org> Date: Fri Apr 07 06:01:01 2017 Add DeathTest suffix to blink_heap_unittests same thread check tests Trying to fix flakiness in mac try bots. Assuming the flakiness is because the tests are running in a threaded context. Adding DeathTest suffix so the tests are run before other tests. BUG=709069 Review-Url: https://codereview.chromium.org/2804143004 Cr-Commit-Position: refs/heads/master@{#462787} [modify] https://crrev.com/324a183e05ececfc2079f06c65c3757354f13fd1/third_party/WebKit/Source/platform/heap/HeapTest.cpp
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43867c81dfd8e0b742015a3391e284753924648a commit 43867c81dfd8e0b742015a3391e284753924648a Author: keishi <keishi@chromium.org> Date: Fri Apr 14 20:15:30 2017 Disable HeapDeathTest.SameThreadCheck* tests on mac Disabling HeapDeathTest.SameThreadCheck* because they occasionaly fail on mac bots. BUG=709069 Review-Url: https://codereview.chromium.org/2819613004 Cr-Commit-Position: refs/heads/master@{#464784} [modify] https://crrev.com/43867c81dfd8e0b742015a3391e284753924648a/third_party/WebKit/Source/platform/heap/HeapTest.cpp |
|||
►
Sign in to add a comment |
|||
Comment 1 by lukasza@chromium.org
, Apr 6 2017The 3 flakes associated with this bug: - All happened on mac_chromium_rel_ng - Are in 3 different (but slightly related tests): - HeapTest.MemberSameThreadCheck - HeapTest.PersistentSameThreadCheck - HeapTest.MarkingSameThreadCheck Some bits from the logs (*) that might be relevant: ... [ RUN ] HeapTest.MemberSameThreadCheck [WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 6 threads. [ OK ] HeapTest.MemberSameThreadCheck (81470 ms) [ RUN ] HeapTest.PersistentSameThreadCheck [WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 2 threads. [ OK ] HeapTest.PersistentSameThreadCheck (39338 ms) [ RUN ] HeapTest.MarkingSameThreadCheck [WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 2 threads. [ OK ] HeapTest.MarkingSameThreadCheck (379 ms)... [110/117] HeapTest.MemberSameThreadCheck (TIMED OUT) ... (*) https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F423338%2F%2B%2Frecipes%2Fsteps%2Fblink_heap_unittests__with_patch_%2F0%2Fstdout