New issue
Advanced search Search tips

Issue 709061 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 707632

Blocking:
issue 709605



Sign in to add a comment

Remove checks in IIRFilter for non-finite values for the filter coefficients

Project Member Reported by rtoy@chromium.org, Apr 6 2017

Issue description

The v8 binding layer now checks that sequence<float> objects actually contain only finite values.  The checks that we have in the IIRFilter aren't needed anymore.
 

Comment 1 by rtoy@chromium.org, Apr 7 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4efea4a5a7e3094b722f3454570b0f216101042d

commit 4efea4a5a7e3094b722f3454570b0f216101042d
Author: rtoy <rtoy@chromium.org>
Date: Fri Apr 07 19:22:17 2017

Remove unneeded checks for finite coefficient values

The v8 bindings layer does the finite check for us so we don't have to
check again.

BUG= 709061 
TEST=covered by existing tests

Review-Url: https://codereview.chromium.org/2804083004
Cr-Commit-Position: refs/heads/master@{#462956}

[modify] https://crrev.com/4efea4a5a7e3094b722f3454570b0f216101042d/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp

Comment 3 by rtoy@chromium.org, Apr 7 2017

Blocking: 709605

Comment 4 by rtoy@chromium.org, Apr 10 2017

Status: Fixed (was: Started)

Sign in to add a comment