New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709055 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

27% regression in system_health.memory_mobile at 461761:461859

Project Member Reported by pmeenan@chromium.org, Apr 6 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=709055

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3OvOrQsM


Bot(s) for this bug's original alert(s):

android-nexus5X
Cc: liber...@chromium.org
Owner: liber...@chromium.org

=== Auto-CCing suspected CL author liberato@chromium.org ===

Hi liberato@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : liberato
  Commit : 29aa3bc7a1fb3b50e9610e35be6eb052f60e4696
  Date   : Tue Apr 04 22:02:53 2017
  Subject: Move routing token out of AndroidOverlay config.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/load_games/load_games_spychase
  Change       : 6.62% | 15789787.4286 -> 16834998.8571

Revision             Result                   N
chromium@461760      15789787 +- 9000051      21      good
chromium@461810      13436928 +- 7458007      14      good
chromium@461835      12497237 +- 4317626      6       good
chromium@461847      11998208 +- 571564       6       good
chromium@461853      11635029 +- 401781       6       good
chromium@461856      13198677 +- 2116452      6       good
chromium@461858      14369109 +- 611544       6       good
chromium@461859      16834999 +- 650492       21      bad       <--

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.spychase system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983050772767989536

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5305479812612096


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
sorry, was ooo.

i'll take a look.  it's unlikely that this CL is related.  it just removes a member from an unused (except for tests) struct, and adds it as a function parameter to a function that also isn't called except for tests.

at least, that's all it's supposed to do.  that's the part i'm going to check :)
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Apr 10 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/load_games/load_games_spychase

Revision             Result                  N
chromium@461544      16728162 +- 577400      21      good
chromium@461859      16781166 +- 599953      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.spychase system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982678358067518336

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5824091342241792


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Looks like the metric has recovered, we can probably close this.
Status: WontFix (was: Assigned)

Sign in to add a comment