Issue metadata
Sign in to add a comment
|
30% regression in battor.steady_state at 461746:461884 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 6 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8983050783849574624
,
Apr 6 2017
=== BISECT JOB RESULTS === Bisect was unable to run to completion Error: INFRA_FAILURE The bisect was able to narrow the range, you can try running with: good_revision: c348edb0c510441efe4ae5b8b1cfccc47f3c15ce bad_revision : 25ea37cccbe86c9e65cf62aed6d1363b3a5aedc5 If failures persist contact the team (see below) and report the error. Bisect Details Configuration: mac_retina_perf_bisect Benchmark : battor.steady_state Metric : cpu_time_percentage_avg/https___instagram.com_cnn_ Revision Result N chromium@461745 0.290977 +- 0.0118279 6 good chromium@461815 0.293746 +- 0.00266326 6 good chromium@461833 0.390152 +- 0.0161979 6 bad chromium@461850 0.383112 +- 0.00189722 6 bad chromium@461884 0.381895 +- 0.00202329 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https...instagram.com.cnn. battor.steady_state Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8983050783849574624 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5810304631439360 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982576160509285728
,
Apr 13 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982417601995895120
,
Apr 13 2017
,
Apr 13 2017
=== Auto-CCing suspected CL author wangxianzhu@chromium.org === Hi wangxianzhu@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : wangxianzhu Commit : 347d17a607d7f379ba66bb4904869c1b530aac2b Date : Tue Apr 04 20:53:55 2017 Subject: setMayNeedPaintInvalidation in setNeedsOverflowRecalcAfterStyleChange() Bisect Details Configuration: mac_retina_perf_bisect Benchmark : battor.steady_state Metric : cpu_time_percentage_avg/https___instagram.com_cnn_ Change : 29.63% | 0.292294272476 -> 0.378889949695 Revision Result N chromium@461815 0.292294 +- 0.00611524 6 good chromium@461824 0.291491 +- 0.00295458 6 good chromium@461827 0.292469 +- 0.00137271 6 good chromium@461828 0.289752 +- 0.0231325 6 good chromium@461829 0.391527 +- 0.00318031 6 bad <-- chromium@461833 0.37889 +- 0.0136567 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https...instagram.com.cnn. battor.steady_state Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8982417601995895120 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5296570049757184 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1def26285e4b62c398bb800dadeeecc566a41900 commit 1def26285e4b62c398bb800dadeeecc566a41900 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Apr 21 03:11:26 2017 Don't include descendants into LocalVisualRect if a box has both mask and overflow clip This avoids unnecessary paint invalidation when the box's descedants change visual overflow which doesn't affect the box's local visual rect because of the overflow clip. About the bug: the page contains the following HTML: <div style="overflow: hidden; -webkit-mask-image: url(#a)> <div class="animating rotation transform"></div> </div> The animating child changes the container's layout overflow. https://codereview.chromium.org/2791933003/ fixed an under-invalidation issue when layout overflow changes, but unnecessarily invalidated the container because previously LayoutBox::LocalVisualRect() also included descendant visual overflow if there is a mask regardless of overflow clip. BUG= 709054 Review-Url: https://codereview.chromium.org/2826273005 Cr-Commit-Position: refs/heads/master@{#466243} [modify] https://crrev.com/1def26285e4b62c398bb800dadeeecc566a41900/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/1def26285e4b62c398bb800dadeeecc566a41900/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
,
Apr 21 2017
,
Apr 21 2017
,
Apr 21 2017
Please tag with applicable OSs. Thanks.
,
Apr 21 2017
,
Apr 21 2017
The performance is tested on Mac only, but the code affects all platforms.
,
Apr 22 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/198917a86accada7eb94e50b93ca0a7253fce823 commit 198917a86accada7eb94e50b93ca0a7253fce823 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sat Apr 22 03:42:04 2017 Don't include descendants into LocalVisualRect if a box has both mask and overflow clip This avoids unnecessary paint invalidation when the box's descedants change visual overflow which doesn't affect the box's local visual rect because of the overflow clip. About the bug: the page contains the following HTML: <div style="overflow: hidden; -webkit-mask-image: url(#a)> <div class="animating rotation transform"></div> </div> The animating child changes the container's layout overflow. https://codereview.chromium.org/2791933003/ fixed an under-invalidation issue when layout overflow changes, but unnecessarily invalidated the container because previously LayoutBox::LocalVisualRect() also included descendant visual overflow if there is a mask regardless of overflow clip. BUG= 709054 Review-Url: https://codereview.chromium.org/2826273005 Cr-Commit-Position: refs/heads/master@{#466243} TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2833263002 Cr-Commit-Position: refs/branch-heads/3071@{#141} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/198917a86accada7eb94e50b93ca0a7253fce823/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/198917a86accada7eb94e50b93ca0a7253fce823/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
,
Apr 22 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pmeenan@chromium.org
, Apr 6 2017