New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 709051 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.5%-8.7% regression in memory.top_10_mobile at 461917:461988

Project Member Reported by pmeenan@chromium.org, Apr 6 2017

Issue description

See the link to graphs below.
 
Cc: vogelheim@chromium.org
Owner: vogelheim@chromium.org

=== Auto-CCing suspected CL author vogelheim@chromium.org ===

Hi vogelheim@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : vogelheim
  Commit : 1769c7034ba4203c6301d5db5e3081b47585af0d
  Date   : Tue Apr 04 15:38:17 2017
  Subject: [parser/ast] Reduce memory consumption for AstConsString.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/foreground/http_search_yahoo_com_search__ylt_p_google
  Change       : 6.36% | 9300047.42857 -> 9891387.55556

Revision                           Result                   N
chromium@461916                    9300047 +- 113226        14      good
chromium@461946                    9296417 +- 115877        14      good
chromium@461961                    9291577 +- 69833.9       9       good
chromium@461962                    9304659 +- 60699.1       6       good
chromium@461962,v8@1769c7034b      10065356 +- 5750.92      6       bad       <--
chromium@461962,v8@6d89de7b9e      10064719 +- 6005.92      6       bad
chromium@461962,v8@0bd9f1b8e6      10064303 +- 5982.92      6       bad
chromium@461962,v8@d0e5df3e17      10063835 +- 5541.24      6       bad
chromium@461963                    10060552 +- 13481.4      6       bad
chromium@461965                    10059425 +- 19822.2      6       bad
chromium@461969                    10062704 +- 4796.93      6       bad
chromium@461976                    9891388 +- 970099        9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983050817987536112

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5798425154551808


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 709053  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Apr 25 2017

Cc: simonhatch@chromium.org rsch...@chromium.org mlippautz@chromium.org sullivan@chromium.org dtu@chromium.org
 Issue 714896  has been merged into this issue.
Status: Assigned (was: Untriaged)
This is actually triaged.
Status: WontFix (was: Assigned)
It's a bummer this didn't get acted on, but most of the alerts were less than 200kib, so at this point i think it's okay to WontFix.

Sign in to add a comment