[Payments] iOS: Reject the show promise under various conditions |
||||
Issue descriptionIf the validation fails on the details passed in by the merchant (options, details, method_data), we should reject the promise.
,
Apr 17 2017
In the absence of "basic-card" method name, the code should perform these two operations: 1) Resolve any caneMakePayment() promise with "false". 2) Reject any show() promise with "NotSupportedError".
,
Jun 27 2017
,
Oct 11 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f2fd127b3f597abbcdeece791353e2c5161df85 commit 3f2fd127b3f597abbcdeece791353e2c5161df85 Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Wed Oct 11 19:55:58 2017 [PR] Improved JS validation of payment methods and shipping options Make the following test cases fully pass: https://w3c-test.org/payment-request/payment-request-constructor.https.html https://w3c-test.org/payment-request/payment-request-constructor-crash.https.html https://w3c-test.org/payment-request/payment-request-ctor-currency-code-checks.https.html https://w3c-test.org/payment-request/payment-request-ctor-pmi-handling.https.html https://w3c-test.org/payment-request/payment-request-show-method.https.html https://w3c-test.org/payment-request/payment-request-show-method.https.html Bug: 709036 Change-Id: Ib9e19bba90893588385c0d11a552adb083f34910 Reviewed-on: https://chromium-review.googlesource.com/713577 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#508077} [modify] https://crrev.com/3f2fd127b3f597abbcdeece791353e2c5161df85/ios/chrome/browser/payments/payment_request.mm [modify] https://crrev.com/3f2fd127b3f597abbcdeece791353e2c5161df85/ios/chrome/browser/web/resources/payment_request.js
,
Oct 11 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rouslan@chromium.org
, Apr 6 2017