fast/canvas/getPutImageDataPairTest.html is slower than Slow |
||||
Issue descriptionwebkit_tests failing on chromium.webkit/WebKit Win7 Builders failed on: - WebKit Win7: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7 Specifically, this test: virtual/gpu/fast/canvas/getPutImageDataPairTest.html is timing out. I can't find a good owner so I'm marking this for blink triage.
,
Apr 6 2017
The test is timing out at 30s. Maybe it can be made faster.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f045f6dffa8407f8ff9cd18437c6557affadbda7 commit f045f6dffa8407f8ff9cd18437c6557affadbda7 Author: schenney <schenney@chromium.org> Date: Fri Apr 07 18:41:47 2017 Mark virtual/gpu/fast/canvas/getPutImageDataPairTest.html as timeout The test is slower than slow. TBR=ellyjones@chromium.org BUG= 709009 Review-Url: https://codereview.chromium.org/2806743002 Cr-Commit-Position: refs/heads/master@{#462939} [modify] https://crrev.com/f045f6dffa8407f8ff9cd18437c6557affadbda7/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/f045f6dffa8407f8ff9cd18437c6557affadbda7/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 12 2017
I will take it, shoudn't be too hard.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc213072bad5a4396bce0b36252eb75b5a94410a commit cc213072bad5a4396bce0b36252eb75b5a94410a Author: Xida Chen <xidachen@chromium.org> Date: Wed Jul 12 17:11:24 2017 Make getPutImageDataPairTest.html pass There are two reasons for this CL: 1. This layout test times out on virtual/gpu/ test suite. 2. The layout test is uses testharness, but it has an expected file. The reason for #1 is that when the test creates a canvas, it uses the canvas's default width and height which is 300*150, and call getImageData and putImageData on the entire canvas with the same color. We really don't need that, this CL sets the width and height to be 5 and should test the same thing. The reason for #2 is that this layout test has several small tests, the name for each small tests are the same, and testharness apparently doesn't like that. This CL removes a line in the expectation file, and some -expected.txt Bug: 709009 Change-Id: I14935f4bf84a8cabb5a9aa56dc502b5d02768b77 Reviewed-on: https://chromium-review.googlesource.com/568079 Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486002} [modify] https://crrev.com/cc213072bad5a4396bce0b36252eb75b5a94410a/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/de99afb4fcca868133a04b659fa13252aa42e57c/third_party/WebKit/LayoutTests/fast/canvas/getPutImageDataPairTest-expected.txt [modify] https://crrev.com/cc213072bad5a4396bce0b36252eb75b5a94410a/third_party/WebKit/LayoutTests/fast/canvas/getPutImageDataPairTest.html [delete] https://crrev.com/de99afb4fcca868133a04b659fa13252aa42e57c/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/getPutImageDataPairTest-expected.txt [delete] https://crrev.com/de99afb4fcca868133a04b659fa13252aa42e57c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu/fast/canvas/getPutImageDataPairTest-expected.txt [delete] https://crrev.com/de99afb4fcca868133a04b659fa13252aa42e57c/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu/fast/canvas/getPutImageDataPairTest-expected.txt
,
Jul 13 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by schenney@chromium.org
, Apr 6 2017Labels: Test-Layout BugSource-Chromium PaintTeamTriaged-20170406 OS-Windows Pri-2 Type-Task
Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)