The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99b481419897f642644932ecab1db0ee7453147e

commit 99b481419897f642644932ecab1db0ee7453147e
Author: fs <fs@opera.com>
Date: Tue May 30 17:42:18 2017

Clean up creation of "detached" SVG* data type objects

Add CreateDetached helpers for the various objects (or, their tear-offs)
that can be created without having a context element. This is in
preparation for replacing some of these with their DOM* counterparts
from the Geometry specifications [1]. The "detached" term is borrowed from
the SVG2 specification [2].
Also drop all of the default arguments that pass QualifiedName::Null(),
and instead explicitly pass them where needed (for detached objects.)

[1] https://drafts.fxtf.org/geometry/
[2] https://svgwg.org/svg2-draft/struct.html#__svg__SVGSVGElement__createSVGNumber

BUG=709001

Review-Url: https://codereview.chromium.org/2912663002
Cr-Commit-Position: refs/heads/master@{#475583}

[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGAngleTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGLengthTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGNumberListTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGNumberTearOff.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGNumberTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGPathElement.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGPointListTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGPointTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGPreserveAspectRatioTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGRectTearOff.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGRectTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGStringListTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGTransformListTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGTransformTearOff.cpp
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/SVGTransformTearOff.h
[modify] https://crrev.com/99b481419897f642644932ecab1db0ee7453147e/third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.h

For the sake of my future self as well as others, I figured I should braindump here, to list stumbling blocks and things that'll need fixing:

 * DOMRect and DOMPoint need to be able to fit into their corresponding SVGAnimated* types. Hopefully a notifier hook is all that will be needed here, but see below.

 * DOMPoint needs to be "listable", i.e be able to reside in a SVGPointList. Hopefully the notifier hook mentioned above will suffice for this as well.

 * The animation engines will need to be taught how to animate DOMRects. This is currently achieved for SVGRect by it being a SVGPropertyBase, so it can use the type tag from there. The actual interpolation/addition/accumulation logic for the SMIL engine also goes in the SVGPropertyBase as things stand today, but that should be possible to separate (and merge with/use the core/animation code instead.)

 * SVGRect contains parsing logic (string => SVGRect) which may need to be externalized. SVGPoint contains the same, but it should never be used (i.e it's essentially dead code.)

 * SVGMatrix is in a relationship with SVGTransform, which means it sometimes share storage of the actual matrix with SVGTransform. This probably needs to be fixed/changed in some way. A notifier hook will be needed here as well.

 * For the "read only" use cases we currently use a bit in SVGPropertyTearOffBase. I suspect we need a new way to handle it for these types.

 * ...and more! (I'm sure)

 * SVGRect has an 'is valid' flag (in addition to x, y, width and height.) We should get rid of that. Maybe via issue 703050.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f488b372798d523f0b6b48f6eec7efa6bf53500

commit 5f488b372798d523f0b6b48f6eec7efa6bf53500
Author: fs <fs@opera.com>
Date: Sun Jun 04 20:41:42 2017

Tidy up SVGListPropertyHelper

Turn some iterations into range-based for-loops. Use operator== from
Vector<...> rather than re-implementing it. Remove FindItem (unused.)
Deduplicate some code, replace 0 with nullptr where appropriate and
simplify the padding loop.

BUG=709001

Review-Url: https://codereview.chromium.org/2920103002
Cr-Commit-Position: refs/heads/master@{#476914}

[modify] https://crrev.com/5f488b372798d523f0b6b48f6eec7efa6bf53500/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h

 Issue 860439  has been merged into this issue.

 Issue 924259  has been merged into this issue.