New issue
Advanced search Search tips

Issue 708980 link

Starred by 1 user
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , All , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

MediaControlsTest should use <video controls>

Project Member Reported by joh...@chromium.org, Apr 6 2017 
third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp tests that the media controls show up and work properly. But the HTML being tested is '<video>' rather than '<video controls>', so it's not clear why the media controls are actually being displayed!

Comment 1 by mlamouri@chromium.org, Apr 19 2017

Labels: M-61
Owner: mlamouri@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by mlamouri@chromium.org, Nov 17 2017

Labels: -M-61 M-64 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/309e4649988810dd5d9be6ba017aa224e7610a90

commit 309e4649988810dd5d9be6ba017aa224e7610a90
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Nov 28 16:42:47 2017

Media Controls: unit tests should have media controls enabled by default.

The test class does not turn on the controls which forces most tests to
do it. Having them on would match expectations.

Bug:  708980 
Change-Id: Ia81e5d27cef30709d01943b2791fe874db0a438f
Reviewed-on: https://chromium-review.googlesource.com/776718
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519707}
[modify] https://crrev.com/309e4649988810dd5d9be6ba017aa224e7610a90/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

Comment 4 by mlamouri@chromium.org, Nov 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment