Clear browsing data button remains enable even if no checkbox is selected.
Reported by
vku...@etouch.net,
Apr 6 2017
|
||||||||||
Issue descriptionChrome Version: 59.0.3064.0 (Official Build) Revision d171113ba68ab33dc071c55d5c023d14328f453d-refs/heads/master@{#462305}(32/64 Bit) OS:Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (Ubuntu 14.04 LTS) What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://md-settings/ (2)Click on 'Advanced' > clear browsing data and uncheck all checkboxes (3)Observe 'clear browsing data' button Actual: Clear browsing data button remains enable even if no checkbox is selected. Expected: Clear browsing data should become disable if no checkbox(i.e any option) is selected. This is a Non-regression issue seen from 'M51' series i.e 51.0.2687.0
,
Apr 6 2017
,
Apr 12 2018
I am able to reproduce this. @dullweber Does clicking on "clear browsing data" do anything if no checkbox is selected? Should it be disabled instead?
,
Apr 12 2018
Clicking "Clear Browsing Data" doesn't do anything if no checkbox is selected. On Android, we disable the button, we should do the same on Desktop.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42d4489808b5fc647d51128b007c909624c16fd3 commit 42d4489808b5fc647d51128b007c909624c16fd3 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Apr 19 09:07:59 2018 Disable clear button if no datatype is selected The clear button in Clear Browsing Data should be disabled if no datatype is selected. This is already the case on Android but missing on Desktop, so it is fixed in this CL. We need to update the button state when the dialog is opened or when a checkbox or the selected tab change. Bug: 708974 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idb3e95edd1c9ad4cdd39ada3e68fb22835ffc9f4 Reviewed-on: https://chromium-review.googlesource.com/1010345 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#551969} [modify] https://crrev.com/42d4489808b5fc647d51128b007c909624c16fd3/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/42d4489808b5fc647d51128b007c909624c16fd3/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js [modify] https://crrev.com/42d4489808b5fc647d51128b007c909624c16fd3/chrome/test/data/webui/settings/privacy_page_test.js
,
Apr 19 2018
,
May 1 2018
Issue 728038 has been merged into this issue. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ranjitkan@chromium.org
, Apr 6 2017